From: David Marchand <david.marchand@redhat.com>
To: Sunil Uttarwar <sunilprakashrao.uttarwar@amd.com>
Cc: dev@dpdk.org, asomalap@amd.com
Subject: Re: [dpdk-dev] [PATCH v6] crypto/ccp: move device from vdev to PCI
Date: Fri, 6 Oct 2023 13:06:40 +0200 [thread overview]
Message-ID: <CAJFAV8z2P6ODiQ_+9JkRbuHbmJJ-wbH6cSTsSc-icZBNyB16ag@mail.gmail.com> (raw)
In-Reply-To: <20210726090821.3833862-1-asomalap@amd.com>
Hello Sunil,
On Mon, Jul 26, 2021 at 11:09 AM <asomalap@amd.com> wrote:
>
> From: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
>
> drop all the code duplicating the PCI bus driver
> developed for enable IOMMU in vdev.
>
> Signed-off-by: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
Looking back in history, this patch converted crypto/ccp to a PCI
driver, but the associated doc is still about vdev.
https://doc.dpdk.org/guides/cryptodevs/ccp.html#initialization
And I also noticed some remnants, like:
drivers/crypto/ccp/meson.build:deps += 'bus_vdev'
drivers/crypto/ccp/rte_ccp_pmd.c:#include <bus_vdev_driver.h>
drivers/crypto/ccp/rte_ccp_pmd.c: CCP_LOG_ERR("failed to
create cryptodev vdev");
Can you send fixes?
Thanks.
--
David Marchand
prev parent reply other threads:[~2023-10-06 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 12:02 [dpdk-dev] [PATCH v4] crypto/ccp: moving vdev to PCI driver asomalap
2021-07-16 12:11 ` David Marchand
2021-07-19 4:46 ` [dpdk-dev] [PATCH v5] " asomalap
2021-07-19 18:55 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-26 9:08 ` [dpdk-dev] [PATCH v6] crypto/ccp: move device from vdev to PCI asomalap
2021-07-27 17:39 ` [dpdk-dev] [EXT] " Akhil Goyal
2023-10-06 11:06 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8z2P6ODiQ_+9JkRbuHbmJJ-wbH6cSTsSc-icZBNyB16ag@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=asomalap@amd.com \
--cc=dev@dpdk.org \
--cc=sunilprakashrao.uttarwar@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).