From: David Marchand <david.marchand@redhat.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: dev <dev@dpdk.org>,
"Ruifeng Wang (Arm Technology China)" <Ruifeng.Wang@arm.com>,
nd <nd@arm.com>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 2/2] test/rcu: address test case failure
Date: Fri, 28 Jun 2019 18:54:28 +0200 [thread overview]
Message-ID: <CAJFAV8z3bu9XsUqXKBxJxsP9=3b47mmVTxioFthKyhf5RMWxeg@mail.gmail.com> (raw)
In-Reply-To: <VE1PR08MB51497FC0E6807967BB30087398FC0@VE1PR08MB5149.eurprd08.prod.outlook.com>
On Fri, Jun 28, 2019 at 6:37 PM Honnappa Nagarahalli <
Honnappa.Nagarahalli@arm.com> wrote:
> On Fri, Jun 28, 2019 at 5:44 AM Honnappa Nagarahalli <
> honnappa.nagarahalli@arm.com<mailto:honnappa.nagarahalli@arm.com>> wrote:
> Test case for rte_rcu_qsbr_get_memsize is written specifically
> for 128 threads. Do not use RTE_MAX_LCORE as it changes for
> different configurations.
>
> Does it mean this test can only work on arm with 256 lcores?
> How many cores does this test require?
> [Honnappa] It tests the correctness of the calculation of the memory
> required. So, it uses the hand calculated number to verify. The hand
> calculated number is for 128 cores. So, it does not depend on the platform
> as such.
>
> Ah ah, funny that the default RTE_MAX_LCORE for x86 is 128, and then I did
> not see the test failing.
> Then ok for this fix.
>
> Reviewed-by: David Marchand <david.marchand@redhat.com<mailto:
> david.marchand@redhat.com>>
>
>
> How about the followup patch:
>
> - TEST_RCU_QSBR_RETURN_IF_ERROR((sz != 8384 && sz != 16768),
> - "Get Memsize for 128 threads");
> + TEST_RCU_QSBR_RETURN_IF_ERROR(
> +#if RTE_CACHE_LINE_SIZE == 64
> + sz != 8384
> +#elif RTE_CACHE_LINE_SIZE == 128
> + sz != 16768
> +#endif
> + , "Get Memsize for 128 threads");
> [Honnappa] Added this change to V2, but slightly differently
>
Yep saw it.
Thanks.
--
David Marchand
next prev parent reply other threads:[~2019-06-28 16:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 3:44 [dpdk-stable] [PATCH 1/2] test/rcu: increase the size of num cores variable Honnappa Nagarahalli
2019-06-28 3:44 ` [dpdk-stable] [PATCH 2/2] test/rcu: address test case failure Honnappa Nagarahalli
2019-06-28 9:16 ` David Marchand
2019-06-28 13:53 ` Honnappa Nagarahalli
2019-06-28 14:09 ` David Marchand
2019-06-28 16:36 ` Honnappa Nagarahalli
2019-06-28 16:54 ` David Marchand [this message]
2019-06-28 9:09 ` [dpdk-stable] [dpdk-dev] [PATCH 1/2] test/rcu: increase the size of num cores variable David Marchand
2019-06-28 13:34 ` Thomas Monjalon
2019-06-28 16:38 ` Honnappa Nagarahalli
2019-06-28 16:35 ` [dpdk-stable] [PATCH v2 " Honnappa Nagarahalli
2019-06-28 16:35 ` [dpdk-stable] [PATCH v2 2/2] test/rcu: address test case failure Honnappa Nagarahalli
2019-06-28 17:11 ` [dpdk-stable] [PATCH v2 1/2] test/rcu: increase the size of num cores variable David Marchand
2019-06-28 18:43 ` [dpdk-stable] [PATCH v3 " Honnappa Nagarahalli
2019-06-28 18:43 ` [dpdk-stable] [PATCH v3 2/2] test/rcu: address test case failure Honnappa Nagarahalli
2019-06-28 18:54 ` [dpdk-stable] [PATCH v3 1/2] test/rcu: increase the size of num cores variable David Marchand
2019-06-29 12:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z3bu9XsUqXKBxJxsP9=3b47mmVTxioFthKyhf5RMWxeg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).