DPDK CI discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	"alialnu@nvidia.com" <alialnu@nvidia.com>,
	 "aconole@redhat.com" <aconole@redhat.com>,
	"ci@dpdk.org" <ci@dpdk.org>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] pw_maintainers_cli: enhance tree selection
Date: Fri, 29 Sep 2023 11:40:06 +0200	[thread overview]
Message-ID: <CAJFAV8z9bi3wR8J+Jpg+UjT-MmJyh5q0x+i11i-f+=UNB9g4oA@mail.gmail.com> (raw)
In-Reply-To: <PH0PR18MB4086677B6E13B659BE6231D3DEC0A@PH0PR18MB4086.namprd18.prod.outlook.com>

On Fri, Sep 29, 2023 at 11:21 AM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
> > -----Original Message-----
> > From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> > Sent: Friday, September 29, 2023 2:05 PM
> > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; alialnu@nvidia.com;
> > aconole@redhat.com
> > Cc: ci@dpdk.org; Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> > Subject: [PATCH] pw_maintainers_cli: enhance tree selection
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > When longest prefix match doesnt find a suitable tree, pick the
> > tree which has the highest modified file count instead of defauting
> > to main tree.
> >

This script helps with the delegation but nothing prevents submitters
or maintainers from updating this in patchwork themselves.

I did not test it but this heuristic seems complex in how it is
affected by existing git history.
It makes this script harder to understand / predict the outcome.
I fear side effects.


>
> This change is need to find the correct branch when a patch has a specification
> Change followed by a implementation of driver layer example:

This should be in the commitlog from the start as it exposes the need,
rather than the solution implemented by the patch.

>
> https://patches.dpdk.org/project/dpdk/list/?series=29675



-- 
David Marchand


  reply	other threads:[~2023-09-29  9:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29  8:34 pbhagavatula
2023-09-29  9:21 ` Pavan Nikhilesh Bhagavatula
2023-09-29  9:40   ` David Marchand [this message]
2023-09-29 10:16     ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-09-29 10:21   ` Thomas Monjalon
2023-09-29 10:54     ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-09-29 11:09       ` Thomas Monjalon
2023-09-29 11:13         ` Jerin Jacob Kollanukkaran
2023-09-29 13:17 ` [PATCH v2] pw_maintainers_cli: enhance ci " pbhagavatula
2023-10-12 12:59   ` Aaron Conole
2023-10-13  5:55     ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-12-07 13:33       ` Pavan Nikhilesh Bhagavatula
2023-12-07 13:44         ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8z9bi3wR8J+Jpg+UjT-MmJyh5q0x+i11i-f+=UNB9g4oA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=aconole@redhat.com \
    --cc=alialnu@nvidia.com \
    --cc=ci@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).