From: David Marchand <david.marchand@redhat.com>
To: Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Xueming Li <xuemingl@nvidia.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Raslan Darawsheh <rasland@nvidia.com>
Subject: Re: [PATCH] vdpa/mlx5: fix leak on event thread creation
Date: Fri, 1 Jul 2022 10:30:33 +0200 [thread overview]
Message-ID: <CAJFAV8z=AZUC_0ZPYnNk=0jMbXDcpMvSQUqciPJbTB4wa=9JKg@mail.gmail.com> (raw)
In-Reply-To: <20220620131044.1858049-1-david.marchand@redhat.com>
On Mon, Jun 20, 2022 at 3:11 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> As stated in the manual, pthread_attr_init return value should be
> checked.
> Besides, a pthread_attr_t should be destroyed once unused.
>
> In practice, we may have no leak (from what I read in glibc current code),
> but this may change in the future.
> Stick to a correct use of the API.
>
> Fixes: 5cf3fd3af4df ("vdpa/mlx5: add CPU core parameter to bind polling thread")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Review, please?
--
David Marchand
next prev parent reply other threads:[~2022-07-01 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 13:10 David Marchand
2022-07-01 8:30 ` David Marchand [this message]
2022-07-01 8:33 ` Maxime Coquelin
2022-07-03 9:46 ` Matan Azrad
2022-07-08 9:12 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z=AZUC_0ZPYnNk=0jMbXDcpMvSQUqciPJbTB4wa=9JKg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).