From: David Marchand <david.marchand@redhat.com>
To: Sunil Kumar Kori <skori@marvell.com>
Cc: Ray Kinsella <mdr@ashroe.eu>, dev <dev@dpdk.org>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 1/2] doc: announce region based device mapping support
Date: Wed, 13 Jul 2022 09:18:14 +0200 [thread overview]
Message-ID: <CAJFAV8zDYj7Y3KJ7VQtJ_MmEtQ1Lt-8+Uup11+wmQdRnTrnd6A@mail.gmail.com> (raw)
In-Reply-To: <20220628135339.2882914-1-skori@marvell.com>
On Tue, Jun 28, 2022 at 3:56 PM <skori@marvell.com> wrote:
>
> From: Sunil Kumar Kori <skori@marvell.com>
>
> Adding region based device mapping support, which enables pci device
> to map only required memory region instead of mapping full BAR.
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 4e5b23c53d..8800a3eb41 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -125,3 +125,16 @@ Deprecation Notices
> applications should be updated to use the ``dmadev`` library instead,
> with the underlying HW-functionality being provided by the ``ioat`` or
> ``idxd`` dma drivers
> +
> +* pci: Update ``rte_pci_device`` and ``rte_pci_driver`` to add region based
> + memory mapping support. There could be a requirement to mmap specific memory
> + region only. Using this mechanism, pci device can be mapped for
> + a given BAR at a given offset of given size.
> +
> + ``rte_pci_device`` will be added with following field
> + ``regions[PCI_MAX_RESOURCE][PCI_MAX_REGION_PER_RESOURCE];``. This field will
> + specify the regions which are mapped for a given BAR.
> +
> + ``rte_pci_driver`` will be added with ``rte_pci_region_map *regions`` and
> + ``valid_bars[PCI_MAX_RESOURCE]``. Using these fields, driver can propagate
> + its region information which are required to be mmap.
I don't think we need a new deprecation notice for this.
We still have Chenbo current notice:
https://git.dpdk.org/dpdk/tree/doc/guides/rel_notes/deprecation.rst#n46
Besides, my proposal hides every bus specific device representations,
and I think it covers your needs too.
See https://patches.dpdk.org/project/dpdk/patch/20220710061736.973563-1-david.marchand@redhat.com/
Did I miss something?
--
David Marchand
next prev parent reply other threads:[~2022-07-13 7:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 13:53 skori
2022-06-28 13:53 ` [PATCH 2/2] bus/pci: support region based device mapping skori
2022-07-07 10:07 ` [PATCH 1/2] doc: announce region based device mapping support Sunil Kumar Kori
2022-07-07 12:39 ` Xia, Chenbo
2022-07-13 7:03 ` Sunil Kumar Kori
2022-07-13 7:27 ` Xia, Chenbo
2022-07-13 7:38 ` Sunil Kumar Kori
2022-07-13 7:18 ` David Marchand [this message]
2022-07-13 7:21 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zDYj7Y3KJ7VQtJ_MmEtQ1Lt-8+Uup11+wmQdRnTrnd6A@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=skori@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).