DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Liron Himi <lironh@marvell.com>
Cc: dev <dev@dpdk.org>, Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] lib/cfgfile: update map file
Date: Tue, 17 Dec 2019 09:43:24 +0100	[thread overview]
Message-ID: <CAJFAV8zF2YRfF6mrm_Z+KHpwU6viGoSwDPRrCraC714jqJUGEw@mail.gmail.com> (raw)
In-Reply-To: <20191217104347.21955-1-lironh@marvell.com>

Comment on the patch title, we never prefix titles with lib/.
This is implicit and just makes the title longer.

Please look at the dpdk git history.
I would go with the 'cfgfile: ' prefix.


On Tue, Dec 17, 2019 at 9:28 AM <lironh@marvell.com> wrote:
>
> From: Liron Himi <lironh@marvell.com>
>
> rte_cfgfile_section_num_entries_by_index was missing from the map
> file.
> meson build failed when calling this function

The problem is not linked to meson, but linking a binary to cfgfile
built as a shared library.


We are missing a Fixes: line and a Cc: stable@dpdk.org (the backport
won't apply cleanly though).

>
> Signed-off-by: Liron Himi <lironh@marvell.com>
> ---
>  lib/librte_cfgfile/rte_cfgfile_version.map | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_cfgfile/rte_cfgfile_version.map b/lib/librte_cfgfile/rte_cfgfile_version.map
> index 906eee96b..b0389e7d8 100644
> --- a/lib/librte_cfgfile/rte_cfgfile_version.map
> +++ b/lib/librte_cfgfile/rte_cfgfile_version.map
> @@ -14,6 +14,7 @@ DPDK_20.0 {
>         rte_cfgfile_save;
>         rte_cfgfile_section_entries;
>         rte_cfgfile_section_entries_by_index;
> +       rte_cfgfile_section_num_entries_by_index;

Those entries must be sorted in alphabetical order.

>         rte_cfgfile_section_num_entries;
>         rte_cfgfile_sections;
>         rte_cfgfile_set_entry;
> --
> 2.23.0
>


-- 
David Marchand


  reply	other threads:[~2019-12-17  8:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 10:43 lironh
2019-12-17  8:43 ` David Marchand [this message]
2019-12-17 11:52 ` [dpdk-dev] [PATCH v2] cfgfile: " lironh
2019-12-17 11:12   ` Dumitrescu, Cristian
2020-01-19 23:31     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8zF2YRfF6mrm_Z+KHpwU6viGoSwDPRrCraC714jqJUGEw@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=lironh@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).