From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 1/2] build: change flag variable type to boolean
Date: Tue, 13 Jun 2023 15:43:34 +0200 [thread overview]
Message-ID: <CAJFAV8zF_Z7w1ZCg94+zMLPPnmb4kZ0-dQqfdgSBXtvzanZEnw@mail.gmail.com> (raw)
In-Reply-To: <20230612171456.173378-1-bruce.richardson@intel.com>
On Mon, Jun 12, 2023 at 7:15 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The has_libnuma flag was using 0 and 1 integer values, instead of the
> more appropriate boolean type. Change to use true/false instead.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
This patch lgtm (with or without the suggestion on config/arm below).
Reviewed-by: David Marchand <david.marchand@redhat.com>
[snip]
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 43f6a551a2..faba5e38cf 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -592,7 +592,7 @@ if update_flags
> part_number = soc_config['part_number']
> soc_flags = soc_config.get('flags', [])
> if not soc_config.get('numa', true)
> - has_libnuma = 0
> + has_libnuma = false
> endif
Maybe has_libnuma = soc_config.get('numa', true) ?
>
> disable_drivers += ',' + soc_config.get('disable_drivers', '')
The same cleanup could be done to has_libfdt.
Additionnally, I wonder if we could remove those "== true" or "==
false" checks here and there in meson.build files.
--
David Marchand
next prev parent reply other threads:[~2023-06-13 13:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 16:21 [PATCH " Bruce Richardson
2023-06-12 16:21 ` [PATCH 2/2] build: prevent accidentally building without NUMA support Bruce Richardson
2023-06-12 17:14 ` [PATCH v2 1/2] build: change flag variable type to boolean Bruce Richardson
2023-06-12 17:14 ` [PATCH v2 2/2] build: prevent accidentally building without NUMA support Bruce Richardson
2023-06-12 17:59 ` Bruce Richardson
2023-06-13 13:50 ` David Marchand
2023-06-13 13:43 ` David Marchand [this message]
2023-06-13 13:55 ` [PATCH v2 1/2] build: change flag variable type to boolean Bruce Richardson
2023-06-13 15:33 ` [PATCH v3 0/2] replace int flags with booleans Bruce Richardson
2023-06-13 15:33 ` [PATCH v3 1/2] build: change NUMA flag variable type to boolean Bruce Richardson
2023-06-13 15:33 ` [PATCH v3 2/2] build: change libfdt " Bruce Richardson
2023-06-14 12:42 ` David Marchand
2023-06-15 13:53 ` [PATCH v3 0/2] replace int flags with booleans David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zF_Z7w1ZCg94+zMLPPnmb4kZ0-dQqfdgSBXtvzanZEnw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).