From: David Marchand <david.marchand@redhat.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>,
Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>,
Chas Williams <3chas3@gmail.com>
Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix source port ID in Rx packets
Date: Thu, 18 Apr 2019 16:06:31 +0200 [thread overview]
Message-ID: <CAJFAV8zLVkmWp6_ENK2kaPHXig0=mtTOGZ2_ER1Kf0ASJAEBAQ@mail.gmail.com> (raw)
In-Reply-To: <20190418130419.25675-1-adrien.mazarguil@6wind.com>
Hey Adrien,
On Thu, Apr 18, 2019 at 3:12 PM Adrien Mazarguil <adrien.mazarguil@6wind.com>
wrote:
> When passed to the application, Rx packets retain the port ID value
> originally set by slave devices. Unfortunately these IDs have no meaning to
> applications, which are typically unaware of their existence.
>
> This confuses those caring about the source port field in mbufs (m->port)
> which experience issues ranging from traffic drop to crashes.
>
> Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD")
>
Cc: stable@dpdk.org
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
> drivers/net/failsafe/failsafe_rxtx.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/net/failsafe/failsafe_rxtx.c
> b/drivers/net/failsafe/failsafe_rxtx.c
> index 231c83291..e78624127 100644
> --- a/drivers/net/failsafe/failsafe_rxtx.c
> +++ b/drivers/net/failsafe/failsafe_rxtx.c
> @@ -61,6 +61,21 @@ failsafe_set_burst_fn(struct rte_eth_dev *dev, int
> force_safe)
> rte_wmb();
> }
>
> +/*
> + * Override source port in Rx packets.
> + *
> + * Make Rx packets originate from this PMD instance instead of one of its
> + * slaves. This is mandatory to avoid breaking applications.
> + */
> +static void
> +failsafe_rx_set_port(struct rte_mbuf **rx_pkts, uint16_t nb_pkts,
> uint16_t port)
> +{
> + unsigned int i;
> +
> + for (i = 0; i != nb_pkts; ++i)
> + rx_pkts[i]->port = port;
> +}
> +
> uint16_t
> failsafe_rx_burst(void *queue,
> struct rte_mbuf **rx_pkts,
> @@ -87,6 +102,9 @@ failsafe_rx_burst(void *queue,
> sdev = sdev->next;
> } while (nb_rx == 0 && sdev != rxq->sdev);
> rxq->sdev = sdev;
> + if (nb_rx)
> + failsafe_rx_set_port(rx_pkts, nb_rx,
> + rxq->priv->dev->data->port_id);
> return nb_rx;
> }
>
> @@ -112,6 +130,9 @@ failsafe_rx_burst_fast(void *queue,
> sdev = sdev->next;
> } while (nb_rx == 0 && sdev != rxq->sdev);
> rxq->sdev = sdev;
> + if (nb_rx)
> + failsafe_rx_set_port(rx_pkts, nb_rx,
> + rxq->priv->dev->data->port_id);
> return nb_rx;
> }
>
> --
> 2.11.0
>
Not a big fan of those duplicated rx_burst functions...
Reviewed-by: David Marchand <david.marchand@redhat.com>
I suppose the bonding pmd has the same issue.
--
David Marchand
next prev parent reply other threads:[~2019-04-18 14:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 13:11 Adrien Mazarguil
2019-04-18 13:11 ` Adrien Mazarguil
2019-04-18 14:06 ` David Marchand [this message]
2019-04-18 14:06 ` David Marchand
2019-04-19 8:08 ` Adrien Mazarguil
2019-04-19 8:08 ` Adrien Mazarguil
2019-04-18 14:08 ` Gaëtan Rivet
2019-04-18 14:08 ` Gaëtan Rivet
2019-04-18 14:42 ` Ferruh Yigit
2019-04-18 14:42 ` Ferruh Yigit
2019-04-18 15:08 ` Adrien Mazarguil
2019-04-18 15:08 ` Adrien Mazarguil
2019-04-18 15:32 ` [dpdk-dev] [PATCH v2] " Adrien Mazarguil
2019-04-18 15:32 ` Adrien Mazarguil
2019-04-18 15:39 ` Thomas Monjalon
2019-04-18 15:39 ` Thomas Monjalon
2019-04-18 15:51 ` Thomas Monjalon
2019-04-18 15:51 ` Thomas Monjalon
2019-04-18 16:46 ` Adrien Mazarguil
2019-04-18 16:46 ` Adrien Mazarguil
2019-04-18 16:54 ` Thomas Monjalon
2019-04-18 16:54 ` Thomas Monjalon
2019-04-18 17:09 ` Adrien Mazarguil
2019-04-18 17:09 ` Adrien Mazarguil
2019-04-18 17:43 ` Thomas Monjalon
2019-04-18 17:43 ` Thomas Monjalon
2019-04-18 15:51 ` Gaëtan Rivet
2019-04-18 15:51 ` Gaëtan Rivet
2019-04-18 17:20 ` [dpdk-dev] [PATCH v3] " Adrien Mazarguil
2019-04-18 17:20 ` Adrien Mazarguil
2019-04-18 18:51 ` Ferruh Yigit
2019-04-18 18:51 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zLVkmWp6_ENK2kaPHXig0=mtTOGZ2_ER1Kf0ASJAEBAQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=3chas3@gmail.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).