From: David Marchand <david.marchand@redhat.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent
Date: Thu, 28 Oct 2021 10:21:03 +0200 [thread overview]
Message-ID: <CAJFAV8zMsUKBEwLSx0-iRmoeygv__1Av5qiu6NQ80db1TVqE+Q@mail.gmail.com> (raw)
In-Reply-To: <MN2PR11MB40638EECECAE8942E1C7DE859CA29@MN2PR11MB4063.namprd11.prod.outlook.com>
On Wed, Sep 22, 2021 at 1:31 PM Xia, Chenbo <chenbo.xia@intel.com> wrote:
>
> > -----Original Message-----
> > From: Yigit, Ferruh <ferruh.yigit@intel.com>
> > Sent: Wednesday, September 22, 2021 5:27 PM
> > To: Xia, Chenbo <chenbo.xia@intel.com>; Burakov, Anatoly
> > <anatoly.burakov@intel.com>; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent
> >
> > On 9/22/2021 4:30 AM, Xia, Chenbo wrote:
> > > Hi Anatoly,
> > >
> > >> -----Original Message-----
> > >> From: dev <dev-bounces@dpdk.org> On Behalf Of Anatoly Burakov
> > >> Sent: Thursday, September 16, 2021 6:37 PM
> > >> To: dev@dpdk.org
> > >> Subject: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent
> > >>
> > >> Currently, when VFIO support is not compiled, FreeBSD and Linux have
> > >> different return values. Fix Linux implementation to follow FreeBSD one.
> > >>
> > >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > >> ---
> > >>
> > >> Notes:
> > >> Current minimum support Linux kernel is 4.4, and Meson build file sets
> > the
> > >
> > > Do you mean currently DPDK support linux >= 4.4? I am not aware of this,
> > could you
> > > show me where it is defined?
> > >
> >
> > https://git.dpdk.org/dpdk/tree/doc/guides/linux_gsg/sys_reqs.rst?h=v21.08#n124
> >
> > Commit d2feae68bf30 ("doc: update minimum supported Linux kernel")
>
> Thanks Ferruh!
>
> About removing the fallback or not, if we decide to remove, maybe for other files
> that check linux kernel version, we also need to change some check because we are
> assuming kernel version >= 4.4 here. If that's a strong requirement, I'll vote for
> yes...
From those comments, it is unclear I can merge this series.
Anatoly?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2021-10-28 8:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 10:36 Anatoly Burakov
2021-09-16 10:36 ` [dpdk-dev] [PATCH v1 2/2] vfio: add errno on unsupported platforms Anatoly Burakov
2021-09-16 10:39 ` Bruce Richardson
2021-09-22 3:31 ` Xia, Chenbo
2021-09-22 3:30 ` [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent Xia, Chenbo
2021-09-22 9:26 ` Ferruh Yigit
2021-09-22 11:30 ` Xia, Chenbo
2021-10-28 8:21 ` David Marchand [this message]
2021-10-28 10:29 ` Burakov, Anatoly
2021-10-28 11:11 ` Xia, Chenbo
2021-10-28 11:32 ` Ferruh Yigit
2021-10-28 13:00 ` Burakov, Anatoly
2021-10-28 14:53 ` Thomas Monjalon
2021-10-28 15:40 ` Burakov, Anatoly
2021-10-28 16:38 ` Stephen Hemminger
2021-10-28 13:49 ` [dpdk-dev] [PATCH v2 1/4] vfio: drop fallback Linux implementation Anatoly Burakov
2021-10-28 13:49 ` [dpdk-dev] [PATCH v2 2/4] vfio: fix wrong return value for FreeBSD Anatoly Burakov
2021-10-28 13:49 ` [dpdk-dev] [PATCH v2 3/4] vfio: fix documentation to match intended behavior Anatoly Burakov
2021-10-28 13:49 ` [dpdk-dev] [PATCH v2 4/4] vfio: add errno on unsupported platforms Anatoly Burakov
2021-10-28 14:13 ` Burakov, Anatoly
2021-10-28 14:15 ` [dpdk-dev] [PATCH v3 1/4] vfio: drop fallback Linux implementation Anatoly Burakov
2021-10-28 14:15 ` [dpdk-dev] [PATCH v3 2/4] vfio: fix wrong return value for FreeBSD Anatoly Burakov
2021-11-05 2:50 ` Xia, Chenbo
2021-10-28 14:15 ` [dpdk-dev] [PATCH v3 3/4] vfio: fix documentation to match intended behavior Anatoly Burakov
2021-11-05 2:57 ` [dpdk-dev] [dpdk-stable] " Xia, Chenbo
2021-10-28 14:15 ` [dpdk-dev] [PATCH v3 4/4] vfio: add errno on unsupported platforms Anatoly Burakov
2021-11-08 15:55 ` [dpdk-dev] [dpdk-stable] " David Marchand
2021-11-01 6:27 ` [dpdk-dev] [PATCH v3 1/4] vfio: drop fallback Linux implementation Xia, Chenbo
2021-11-01 13:57 ` Burakov, Anatoly
2021-11-05 2:48 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zMsUKBEwLSx0-iRmoeygv__1Av5qiu6NQ80db1TVqE+Q@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).