From: David Marchand <david.marchand@redhat.com>
To: Srikanth Yalavarthi <syalavarthi@marvell.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: Aaron Conole <aconole@redhat.com>,
Igor Russkikh <irusskikh@marvell.com>,
dev@dpdk.org, sshankarnara@marvell.com, aprabhu@marvell.com,
ptakkar@marvell.com, stable@dpdk.org
Subject: Re: [PATCH v5 1/1] build: add libarchive to external deps
Date: Mon, 6 Nov 2023 17:03:10 +0100 [thread overview]
Message-ID: <CAJFAV8zVtkg5Mjp=6HF7WL+kufi0RxB-ov5oyde76fwOGjfhZA@mail.gmail.com> (raw)
In-Reply-To: <20231106041243.13621-1-syalavarthi@marvell.com>
On Mon, Nov 6, 2023 at 5:12 AM Srikanth Yalavarthi
<syalavarthi@marvell.com> wrote:
>
> In order to avoid linking with Libs.private, libarchive
> is not added to ext_deps during the meson setup stage.
>
> Since libarchive is not added to ext_deps, cross-compilation
> or native compilation with libarchive installed in non-standard
> location fails with errors related to "cannot find -larchive"
> or "archive.h: No such file or directory". In order to fix the
> build failures, user is required to define the 'c_args' and
> 'c_link_args' with '-I<includedir>' and '-L<libdir>'.
>
> This patch adds libarchive to ext_deps and further would not
> require setting c_args and c_link_args externally.
>
> Fixes: 40edb9c0d36b ("eal: handle compressed firmware")
> Cc: stable@dpdk.org
>
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
This breaks static compilation of applications.
This can be reproduced with test-meson-builds.sh and in GHA (which was
not linking examples statically, I added a patch in my github repo):
https://github.com/david-marchand/dpdk/actions/runs/6772879600/job/18406442129#step:19:19572
--
David Marchand
next prev parent reply other threads:[~2023-11-06 16:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 17:01 [PATCH 1/1] build: update link args and includes for libarchive Srikanth Yalavarthi
2023-10-23 9:26 ` Bruce Richardson
2023-10-23 11:40 ` [EXT] " Srikanth Yalavarthi
2023-10-23 11:53 ` Bruce Richardson
2023-10-23 12:46 ` Srikanth Yalavarthi
2023-10-23 13:00 ` Bruce Richardson
2023-10-23 13:06 ` Bruce Richardson
2023-10-23 14:01 ` Srikanth Yalavarthi
2023-10-26 12:53 ` Srikanth Yalavarthi
2023-10-29 8:10 ` [PATCH v2 1/1] build: add libarchive to external deps Srikanth Yalavarthi
2023-10-29 8:20 ` [PATCH v3 " Srikanth Yalavarthi
2023-11-03 16:38 ` [PATCH v4 " Srikanth Yalavarthi
2023-11-03 16:50 ` Bruce Richardson
2023-11-06 4:27 ` [EXT] " Srikanth Yalavarthi
2023-11-06 4:12 ` [PATCH v5 " Srikanth Yalavarthi
2023-11-06 8:53 ` Bruce Richardson
2023-11-06 15:24 ` Thomas Monjalon
2023-11-06 15:32 ` Thomas Monjalon
2023-11-06 16:03 ` David Marchand [this message]
2023-11-06 16:23 ` Bruce Richardson
2023-11-06 18:17 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zVtkg5Mjp=6HF7WL+kufi0RxB-ov5oyde76fwOGjfhZA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=aprabhu@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=irusskikh@marvell.com \
--cc=ptakkar@marvell.com \
--cc=sshankarnara@marvell.com \
--cc=stable@dpdk.org \
--cc=syalavarthi@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).