From: David Marchand <david.marchand@redhat.com>
To: Ali Alnubani <alialnu@nvidia.com>
Cc: dev <dev@dpdk.org>,
michaelba@mellanox.com, dpdk stable <stable@dpdk.org>
Subject: Re: [PATCH] net/mlx5: fix build with clang 14
Date: Wed, 11 May 2022 16:04:26 +0200 [thread overview]
Message-ID: <CAJFAV8zWC-zp5Bpmb_KwdN3b57UNjP1sVkXmbCYk_K4=VVLGTw@mail.gmail.com> (raw)
In-Reply-To: <20220511135815.1564053-1-alialnu@nvidia.com>
On Wed, May 11, 2022 at 3:59 PM Ali Alnubani <alialnu@nvidia.com> wrote:
>
> Use fgets instead of fscanf to resolve the following warning
> reported by clang 14.0.0 in Fedora 37 (Rawhide):
>
> drivers/net/mlx5/linux/mlx5_ethdev_os.c:1137:52: error:
> 'fscanf' may overflow; destination buffer in argument 3 has size 16,
> but the corresponding specifier may require size 17
> [-Werror,-Wfortify-source]
> ret = fscanf(file, "%" RTE_STR(IF_NAMESIZE) "s", port_name);
>
> Fixes: 63d1db710fbc ("net/mlx5: fix unlimited parsing of switch info")
> Cc: michaelba@mellanox.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> ---
> drivers/net/mlx5/linux/mlx5_ethdev_os.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
> index 8fe73f1adb..3d28597e7b 100644
> --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
> +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
> @@ -1118,7 +1118,7 @@ mlx5_sysfs_switch_info(unsigned int ifindex, struct mlx5_switch_info *info)
> bool port_switch_id_set = false;
> bool device_dir = false;
> char c;
> - int ret;
> + char *ret;
>
> if (!if_indextoname(ifindex, ifname)) {
> rte_errno = errno;
> @@ -1134,9 +1134,9 @@ mlx5_sysfs_switch_info(unsigned int ifindex, struct mlx5_switch_info *info)
>
> file = fopen(phys_port_name, "rb");
> if (file != NULL) {
> - ret = fscanf(file, "%" RTE_STR(IF_NAMESIZE) "s", port_name);
> + ret = fgets(port_name, IF_NAMESIZE, file);
> fclose(file);
> - if (ret == 1)
> + if (ret != NULL)
> mlx5_translate_port_name(port_name, &data);
You can directly check fgets return value and remove (misleading)
variable ret from the global scope of this function.
> }
> file = fopen(phys_switch_id, "rb");
--
David Marchand
next prev parent reply other threads:[~2022-05-11 14:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 13:58 Ali Alnubani
2022-05-11 14:04 ` David Marchand [this message]
2022-05-11 16:41 ` [PATCH v2] " Ali Alnubani
2022-06-15 8:16 ` Thomas Monjalon
2022-06-15 8:41 ` David Marchand
2022-06-15 8:21 ` Slava Ovsiienko
2022-06-15 10:08 ` Raslan Darawsheh
2022-05-18 9:11 [PATCH] " David Marchand
2022-06-10 13:54 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zWC-zp5Bpmb_KwdN3b57UNjP1sVkXmbCYk_K4=VVLGTw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=alialnu@nvidia.com \
--cc=dev@dpdk.org \
--cc=michaelba@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).