test suite reviews and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Zhimin Huang <zhiminx.huang@intel.com>,
	"Chen, Zhaoyan" <zhaoyan.chen@intel.com>
Cc: dts@dpdk.org, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	 "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dts] [PATCH V1] iavf_flexible_descriptor:sync plan and case to adapt dpdk code changed
Date: Thu, 28 Oct 2021 11:44:25 +0200	[thread overview]
Message-ID: <CAJFAV8zd8wgvrg1WPeQY-i4pkt4ZV5rBGyuM1y=0iD+47zraoA@mail.gmail.com> (raw)
In-Reply-To: <20211028180239.4645-1-zhiminx.huang@intel.com>

On Thu, Oct 28, 2021 at 11:33 AM Zhimin Huang <zhiminx.huang@intel.com> wrote:
>
> according to dpdk commit daa02b5cddbb8e11b31d41e2bf7bb1ae64dcae2f code changed.
> fix code to adapt dpdk changed,and add check function after modify code in case.

Please stop changing DPDK source code in the test tool.


>
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
> ---
>  .../iavf_flexible_descriptor_test_plan.rst    |  2 +-
>  tests/TestSuite_iavf_flexible_descriptor.py   | 23 ++++++++++++++++++-
>  2 files changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/test_plans/iavf_flexible_descriptor_test_plan.rst b/test_plans/iavf_flexible_descriptor_test_plan.rst
> index d03fbe41..9cf0d713 100644
> --- a/test_plans/iavf_flexible_descriptor_test_plan.rst
> +++ b/test_plans/iavf_flexible_descriptor_test_plan.rst
> @@ -106,7 +106,7 @@ The default DPDK don't support dump flexible descriptor fields, so need to patch
>        (int)mb->nb_segs);
>        ol_flags = mb->ol_flags;
>        +                rte_pmd_ifd_dump_proto_xtr_metadata(mb);
> -      if (ol_flags & PKT_RX_RSS_HASH) {
> +      if (ol_flags & RTE_MBUF_F_RX_RSS_HASH) {
>        MKDUMPSTR(print_buf, buf_size, cur_len,
>        " - RSS hash=0x%x",
>


-- 
David Marchand


      parent reply	other threads:[~2021-10-28  9:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 18:02 Zhimin Huang
2021-10-28  9:37 ` Huang, ZhiminX
2021-10-28  9:44 ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8zd8wgvrg1WPeQY-i4pkt4ZV5rBGyuM1y=0iD+47zraoA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dts@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    --cc=zhaoyan.chen@intel.com \
    --cc=zhiminx.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).