DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, Ray Kinsella <mdr@ashroe.eu>,
	 Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	 Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	 Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [PATCH] eal: remove panic on remote launch failure
Date: Fri, 30 Sep 2022 09:17:52 +0200	[thread overview]
Message-ID: <CAJFAV8zhtm3-wb5=yt0esNV_6h4scOHVOP7ZoeJj+5mdbSsuCQ@mail.gmail.com> (raw)
In-Reply-To: <20220929105101.406724-1-bruce.richardson@intel.com>

On Thu, Sep 29, 2022 at 12:51 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> Library functions should not cause the app to exit or panic. Replace the
> existing panic call in the EAL remote launch functions with an error
> code return instead.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

LGTM with an update of the release notes (that I will add when merging
if there is no futher comment/objection).

Reviewed-by: David Marchand <david.marchand@redhat.com>

-- 
David Marchand


  reply	other threads:[~2022-09-30  7:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 10:51 Bruce Richardson
2022-09-30  7:17 ` David Marchand [this message]
2022-10-03  7:16   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8zhtm3-wb5=yt0esNV_6h4scOHVOP7ZoeJj+5mdbSsuCQ@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=mdr@ashroe.eu \
    --cc=navasile@linux.microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).