From: David Marchand <david.marchand@redhat.com>
To: Anand Rawat <anand.rawat@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH 0/6] HelloWorld example for Windows
Date: Mon, 4 Mar 2019 11:14:42 +0100 [thread overview]
Message-ID: <CAJFAV8ziGc1+tAWb_TX0wwYo4AYwpaH=hiWjeJLL3esfrZAkFw@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8ya5Qmuxa0apGzDLe6bcrSr6bjCG5=hVxFHw8k4pW91fg@mail.gmail.com>
Sorry Bruce, wrong dest :-)
--
David Marchand
On Mon, Mar 4, 2019 at 11:13 AM David Marchand <david.marchand@redhat.com>
wrote:
>
>
> On Fri, Mar 1, 2019 at 2:48 PM Bruce Richardson <
> bruce.richardson@intel.com> wrote:
>
>> On Thu, Feb 28, 2019 at 11:18:41PM -0800, Anand Rawat wrote:
>> > Helloworld example for Windows.
>> > Includes Windows-specific EAL changes and meson
>> > changes to build the code on Windows.
>> >
>> > Anand Rawat (6):
>> > eal: eal stub to add windows support
>> > eal: Add header files to support windows
>> > eal: Add headers for compatibility with windows environment
>> > eal: add minimum viable code for eal on windows
>> > examples: Add meson changes for windows
>> > doc: add documention for windows
>> >
>> Thanks for this, it's good to see some progress here with small managable
>> patches.
>>
>> I've just tried this on my laptop using clang + meson + ninja. I see some
>> warnings at the link phase due to unknown flags, but otherwise things
>> compile and link ok and I get helloworld app running and printing hello
>> from all cores. Specifying a coremask doesn't seem to work though -
>> perhaps
>> something to look at for a V2.
>>
>
> Some easy warnings to fix:
>
> [dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh
>
> ### eal: eal stub to add windows support
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #402: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:9:
> +eal_cpu_core_id(unsigned lcore_id)
>
> total: 0 errors, 1 warnings, 461 lines checked
> Warning in /lib/librte_eal/winapp/eal/eal_debug.c:
> Using rte_panic/rte_exit
>
> ### eal: add minimum viable code for eal on windows
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #239: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:10:
> + unsigned numTotalProcessors;
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #240: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:11:
> + unsigned numProcessorSockets;
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #241: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:12:
> + unsigned numProcessorCores;
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #242: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:13:
> + unsigned reserved;
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #280: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:50:
> + unsigned lcore = 0;
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #281: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:51:
> + for (unsigned socket = 0; socket <
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #283: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:53:
> + for (unsigned core = 0; core < (win_cpu_map.numProcessorCores /
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #304: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:73:
> +eal_cpu_detected(unsigned lcore_id)
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #313: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:80:
> +eal_cpu_socket_id(unsigned lcore_id)
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #320: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:87:
> +eal_cpu_core_id(unsigned lcore_id)
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #348: FILE: lib/librte_eal/winapp/eal/eal_thread.c:15:
> +RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY;
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #356: FILE: lib/librte_eal/winapp/eal/eal_thread.c:23:
> +rte_eal_remote_launch(lcore_function_t *f, void *arg, unsigned slave_id)
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #388: FILE: lib/librte_eal/winapp/eal/eal_thread.c:55:
> +eal_thread_init_master(unsigned lcore_id)
>
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #406: FILE: lib/librte_eal/winapp/eal/eal_thread.c:73:
> + unsigned lcore_id;
>
> total: 0 errors, 14 warnings, 502 lines checked
> Warning in /lib/librte_eal/winapp/eal/eal.c:
> Using rte_panic/rte_exit
>
> 4/6 valid patches
>
> [dmarchan@dmarchan dpdk]$ ./devtools/check-git-log.sh
> Wrong headline uppercase:
> eal: Add header files to support windows
> eal: Add headers for compatibility with windows environment
> examples: Add meson changes for windows
> Wrong tag:
> Signed-off-by: Kadam, Pallavi <pallavi.kadam@intel.com>
> Signed-off-by: Kadam, Pallavi <pallavi.kadam@intel.com>
> Signed-off-by: Kadam, Pallavi <pallavi.kadam@intel.com>
> Signed-off-by: Kadam, Pallavi <pallavi.kadam@intel.com>
> Signed-off-by: Kadam, Pallavi <pallavi.kadam@intel.com>
> Signed-off-by: Kadam, Pallavi <pallavi.kadam@intel.com>
>
>
> --
> David Marchand
>
next prev parent reply other threads:[~2019-03-04 10:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 7:18 Anand Rawat
2019-03-01 7:18 ` [dpdk-dev] [PATCH 1/6] eal: eal stub to add windows support Anand Rawat
2019-03-01 14:03 ` Thomas Monjalon
2019-03-01 14:17 ` Bruce Richardson
2019-03-01 14:30 ` Thomas Monjalon
2019-03-01 15:19 ` Luca Boccassi
2019-03-01 7:18 ` [dpdk-dev] [PATCH 2/6] eal: Add header files to support windows Anand Rawat
2019-03-01 7:18 ` [dpdk-dev] [PATCH 3/6] eal: Add headers for compatibility with windows environment Anand Rawat
2019-03-01 7:18 ` [dpdk-dev] [PATCH 4/6] eal: add minimum viable code for eal on windows Anand Rawat
2019-03-01 7:18 ` [dpdk-dev] [PATCH 5/6] examples: Add meson changes for windows Anand Rawat
2019-03-01 7:18 ` [dpdk-dev] [PATCH 6/6] doc: add documention " Anand Rawat
2019-03-01 19:02 ` Stephen Hemminger
2019-03-02 2:41 ` Ranjit Menon
2019-03-06 8:33 ` Thomas Monjalon
2019-03-01 13:47 ` [dpdk-dev] [PATCH 0/6] HelloWorld example for Windows Bruce Richardson
2019-03-04 10:13 ` David Marchand
2019-03-04 10:14 ` David Marchand [this message]
2019-03-05 23:43 ` Anand Rawat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8ziGc1+tAWb_TX0wwYo4AYwpaH=hiWjeJLL3esfrZAkFw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anand.rawat@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).