From: David Marchand <david.marchand@redhat.com>
To: Adrian Moreno <amorenoz@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user
Date: Thu, 16 Jul 2020 10:18:11 +0200 [thread overview]
Message-ID: <CAJFAV8zn8uTvN_5fCxubAxVG1geSFg9ndr=ckWonVqCr7QDQ1Q@mail.gmail.com> (raw)
In-Reply-To: <506d7594-efd0-ed82-2f3a-6306540c7cc1@redhat.com>
On Thu, Jul 16, 2020 at 9:53 AM Adrian Moreno <amorenoz@redhat.com> wrote:
> >> + if (ret > UINT8_MAX) {
> >> + PMD_INIT_LOG(ERR, "Invalid VHOST_USER_GET_STATUS
> >> response 0x%" PRIx64 "\n", ret);
> >
> > There's a coding style issue here:
> > CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
> > Could you fix this?
>
> I did see this one as well. It also seems new because PRIx64 is widely used in DPDK.
>
> find -iname *.c | xargs grep -i "PRIx64" | wc -l
> 520
>
> So, ether we have to modify the script to ignore this one or change all 520
> cases, right?
This is a false positive.
We won't drop use of this standard macro because checkpatch is not
happy with it.
I don't see how to silence this warning but I can see that the kernel
uses this macro: so I guess people are simply ignoring this one.
--
David Marchand
next prev parent reply other threads:[~2020-07-16 8:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 17:18 [dpdk-dev] [PATCH 0/5] Add support for GET/SET_STATUS on virtio-user pmd Adrian Moreno
2020-07-15 17:18 ` [dpdk-dev] [PATCH 1/5] net/virtio: split virtio-net and virtio status Adrian Moreno
2020-07-15 17:18 ` [dpdk-dev] [PATCH 2/5] net/virtio: add DEVICE_NEEDS_RESET status bit Adrian Moreno
2020-07-16 2:26 ` Xia, Chenbo
2020-07-16 7:34 ` Adrian Moreno
2020-07-16 8:14 ` Xia, Chenbo
2020-07-15 17:18 ` [dpdk-dev] [PATCH 3/5] net/virtio: add VIRTIO_SET_STATUS support to Virtio-user Adrian Moreno
2020-07-16 3:15 ` Xia, Chenbo
2020-07-16 7:43 ` Adrian Moreno
2020-07-16 8:58 ` Xia, Chenbo
2020-07-16 9:51 ` Adrian Moreno
2020-07-16 11:18 ` Xia, Chenbo
2020-07-15 17:18 ` [dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user Adrian Moreno
2020-07-16 3:31 ` Xia, Chenbo
2020-07-16 7:53 ` Adrian Moreno
2020-07-16 8:18 ` David Marchand [this message]
2020-07-16 8:28 ` Adrian Moreno
2020-07-15 17:18 ` [dpdk-dev] [PATCH 5/5] net/virtio: enable feature checking on virtio-user Adrian Moreno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zn8uTvN_5fCxubAxVG1geSFg9ndr=ckWonVqCr7QDQ1Q@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=amorenoz@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).