From: David Marchand <david.marchand@redhat.com>
To: Elena Agostini <eagostini@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Bing Zhao <bingz@nvidia.com>
Subject: Re: [PATCH v1] bus/pci: get PCI address from rte_device
Date: Wed, 18 Oct 2023 13:00:07 +0200 [thread overview]
Message-ID: <CAJFAV8znviyOoME3fGi-nLR4RU+1kgJ-g9u4TNmw6znmm38+=Q@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8wHDyF7MuR94BVEN6ErLCOE_UhekHCz6127gon+GmiUVA@mail.gmail.com>
On Wed, May 31, 2023 at 11:52 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> (I reformatted the mail a bit)
>
> On Wed, May 31, 2023 at 10:51 AM Elena Agostini <eagostini@nvidia.com> wrote:
> > > On Wed, May 31, 2023 at 10:44 AM Elena Agostini eagostini@nvidia.com wrote:
> > > > > On Tue, May 30, 2023 at 1:48 PM eagostini@nvidia.com wrote:
> > > > > > From: Elena Agostini eagostini@nvidia.com
> > > > > > In DPDK 22.11 pci bus related structure have been hidden internally
> > > > > > so the application doesn't have a direct access to those info anymore.
> > > > > > This patch introduces a get function to retrieve a PCI address
> > > > > > from an rte_device handler.
> > > > > > Signed-off-by: Elena Agostini eagostini@nvidia.com
>
> > > > > I would prefer we don't add specific bus API when there is an alternative.
> > > > > The PCI address is already reported as a string in the generic device
> > > > > object name.
> > > > > Would that be enough for your usecase?
>
> > > > No as I need to parse anyway the PCI address string in the form of domain/bus/devid/function.
>
> > > I am curious. Can you explain why you would need such information?
>
> > Use-case is the Aerial 5G where two processes have to exchange info
> > about PCI devices sending messages according to some specific format.
>
> It seems strange that different processes need to exchange this bus
> level information.
> For dataplane, having a simpler metadata (like a portid maybe?) is
> better than a domain/bus/devid/function quartet.
> For controlplane, having an abstraction or a human readable string is
> probably better too.
>
> In any case, for what you request here, the application can parse the
> generic device name into a rte_pci_addr via rte_pci_addr_parse().
> Is it not enough?
No reply for some time now, marking this patch as rejected.
--
David Marchand
prev parent reply other threads:[~2023-10-18 11:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 11:42 eagostini
2023-05-30 13:47 ` Thomas Monjalon
2023-05-31 8:03 ` David Marchand
2023-05-31 8:44 ` Elena Agostini
2023-05-31 8:47 ` David Marchand
2023-05-31 8:51 ` Elena Agostini
2023-05-31 9:52 ` David Marchand
2023-10-18 11:00 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8znviyOoME3fGi-nLR4RU+1kgJ-g9u4TNmw6znmm38+=Q@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).