From: David Marchand <david.marchand@redhat.com>
To: Yuan Wang <yuanx.wang@intel.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>, dev <dev@dpdk.org>,
Jiayu Hu <jiayu.hu@intel.com>,
"He, Xingguang" <xingguang.he@intel.com>,
Cheng Jiang <cheng1.jiang@intel.com>,
Harman Kalra <hkalra@marvell.com>, dpdk stable <stable@dpdk.org>
Subject: Re: [PATCH] net/virtio-user: restore callfds index for Rx interrupts
Date: Mon, 4 Jul 2022 09:42:14 +0200 [thread overview]
Message-ID: <CAJFAV8zqTU5TZnA3nvqifFFHK7nv1=VV-KnJNfyca7d98x-Gjg@mail.gmail.com> (raw)
In-Reply-To: <20220704070428.2051264-1-yuanx.wang@intel.com>
On Mon, Jul 4, 2022 at 9:11 AM Yuan Wang <yuanx.wang@intel.com> wrote:
>
> The callfds[] array stores eventfds sequentially for Rx and Tx vq.
>
> Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
Good catch...
This is what I had fixed in 848e93d9001e ("net/virtio-user: fix Rx
interrupts with multi-queue").
I suppose the issue has been reintroduced when rebasing Harman series.
> ---
> drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> index 35aa76b1ff..f9cada05e4 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> @@ -417,7 +417,7 @@ virtio_user_fill_intr_handle(struct virtio_user_dev *dev)
>
> for (i = 0; i < dev->max_queue_pairs; ++i) {
> if (rte_intr_efds_index_set(eth_dev->intr_handle, i,
> - dev->callfds[i]))
> + dev->callfds[2 * i + VTNET_SQ_RQ_QUEUE_IDX]))
> return -rte_errno;
> }
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2022-07-04 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 7:04 Yuan Wang
2022-07-04 7:42 ` David Marchand [this message]
2022-07-05 10:53 ` Thomas Monjalon
2022-07-04 8:31 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zqTU5TZnA3nvqifFFHK7nv1=VV-KnJNfyca7d98x-Gjg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=xingguang.he@intel.com \
--cc=yuanx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).