From: "Jérôme Jutteau" <jerome.jutteau@outscale.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/3] vhost: check that a device exists during reset_owner
Date: Mon, 19 Oct 2015 11:42:44 +0200 [thread overview]
Message-ID: <CAJFondOqFAC=yQt-ta68cqdxiCBBvveEWLCM83ofoFQzm8_iGw@mail.gmail.com> (raw)
In-Reply-To: <20151019043548.GO3115@yliu-dev.sh.intel.com>
Hi Yuanhan,
2015-10-19 6:35 GMT+02:00 Yuanhan Liu <yuanhan.liu@linux.intel.com>:
> I would call get_device() here, which dumps an error message when
> it's NULL so that user will get noticed.
>
> Besides that, the 3 patches look good to me, and,
>
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Thanks for your review, a v2 is coming soon with get_device().
--
Jérôme
next prev parent reply other threads:[~2015-10-19 9:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 9:08 [dpdk-dev] [PATCH 0/3] vhost: Fix virtio-net on VHOST_USER_RESET_OWNER Jerome Jutteau
2015-10-16 9:08 ` [dpdk-dev] [PATCH 1/3] vhost: avoid device identifier to be reset to 0 in reset_owner Jerome Jutteau
2015-10-16 9:08 ` [dpdk-dev] [PATCH 2/3] vhost: check that a device exists during reset_owner Jerome Jutteau
2015-10-19 4:35 ` Yuanhan Liu
2015-10-19 9:42 ` Jérôme Jutteau [this message]
2015-10-16 9:08 ` [dpdk-dev] [PATCH 3/3] vhost: protect user_get_vring_base from unknown devices Jerome Jutteau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFondOqFAC=yQt-ta68cqdxiCBBvveEWLCM83ofoFQzm8_iGw@mail.gmail.com' \
--to=jerome.jutteau@outscale.com \
--cc=dev@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).