From: Patrick Robb <probb@iol.unh.edu>
To: Luca Vizzarro <luca.vizzarro@arm.com>
Cc: dev@dpdk.org, "Paul Szczepanek" <paul.szczepanek@arm.com>,
"Tomáš Ďurovec" <tomas.durovec@pantheon.tech>
Subject: Re: [PATCH v2 5/7] dts: add support for externally compiled DPDK
Date: Mon, 28 Oct 2024 21:19:08 -0400 [thread overview]
Message-ID: <CAJvnSUBBTVG0pj-fjLdATRJUztTUYaGkOy9YfVREhbZP7WG+Kw@mail.gmail.com> (raw)
In-Reply-To: <20241021134935.1210500-6-luca.vizzarro@arm.com>
[-- Attachment #1: Type: text/plain, Size: 2247 bytes --]
On Mon, Oct 21, 2024 at 9:50 AM Luca Vizzarro <luca.vizzarro@arm.com> wrote:
> From: Tomáš Ďurovec <tomas.durovec@pantheon.tech>
>
> Enable the user to use either a DPDK source tree directory or a
> tarball, with and without a pre-built build directory. These can be
> stored on either SUT node or the DTS host. The DPDK build setup or the
> pre-built binaries can be specified through the configuration file,
> the command line arguments or environment variables.
>
> Signed-off-by: Tomáš Ďurovec <tomas.durovec@pantheon.tech>
> Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
> ---
> dts/conf.yaml | 24 +-
> dts/framework/config/__init__.py | 123 ++++++-
> dts/framework/config/conf_yaml_schema.json | 62 +++-
> dts/framework/config/types.py | 17 +-
> dts/framework/exception.py | 4 +-
> dts/framework/remote_session/dpdk_shell.py | 2 +-
> dts/framework/runner.py | 8 +-
> dts/framework/settings.py | 200 +++++++++--
> dts/framework/test_result.py | 23 +-
> dts/framework/testbed_model/node.py | 22 +-
> dts/framework/testbed_model/os_session.py | 63 +++-
> dts/framework/testbed_model/posix_session.py | 39 ++-
> dts/framework/testbed_model/sut_node.py | 351 +++++++++++++------
> 13 files changed, 732 insertions(+), 206 deletions(-)
>
> diff --git a/dts/conf.yaml b/dts/conf.yaml
> index 814744a1fc..8a65a481d6 100644
> --- a/dts/conf.yaml
> +++ b/dts/conf.yaml
> @@ -5,12 +5,24 @@
> test_runs:
> # define one test run environment
> - dpdk_build:
> - arch: x86_64
> - os: linux
> - cpu: native
> - # the combination of the following two makes CC="ccache gcc"
> - compiler: gcc
> - compiler_wrapper: ccache
> + # dpdk_tree: Commented out because `tarball` is defined.
>
Should this key name be extended to clarify the desired value is a path,
and whether it is absolute or relative?
+1 to Dean's concerns about using the tarball without --tarball flag if
dpdk_tree is commented out and tarball is defined.
Reviewed-by: Patrick Robb <probb@iol.unh.edu>
[-- Attachment #2: Type: text/html, Size: 2988 bytes --]
next prev parent reply other threads:[~2024-10-29 1:20 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 16:01 [PATCH 0/7] DTS external DPDK build Tomáš Ďurovec
2024-09-30 16:01 ` [PATCH 1/7] dts: rename build target to " Tomáš Ďurovec
2024-09-30 16:01 ` [PATCH 2/7] dts: one dpdk build per test run Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 3/7] dts: fix remote session file transfer vars Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 4/7] dts: add the ability to copy directories via remote Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 5/7] dts: add support for externally compiled DPDK Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 6/7] doc: update argument options for external DPDK build Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 7/7] dts: remove git ref option Tomáš Ďurovec
2024-10-21 13:49 ` [PATCH v2 0/7] DTS external DPDK build Luca Vizzarro
2024-10-21 13:49 ` [PATCH v2 1/7] dts: rename build target to " Luca Vizzarro
2024-10-25 18:05 ` Dean Marx
2024-10-29 1:29 ` Patrick Robb
2024-10-21 13:49 ` [PATCH v2 2/7] dts: enforce one dpdk build per test run Luca Vizzarro
2024-10-25 18:08 ` Dean Marx
2024-10-29 1:29 ` Patrick Robb
2024-10-21 13:49 ` [PATCH v2 3/7] dts: fix remote session file transfer vars Luca Vizzarro
2024-10-21 13:49 ` [PATCH v2 4/7] dts: enable copying directories to and from nodes Luca Vizzarro
2024-10-25 18:12 ` Dean Marx
2024-10-29 1:07 ` Patrick Robb
2024-10-29 12:00 ` Luca Vizzarro
2024-10-21 13:49 ` [PATCH v2 5/7] dts: add support for externally compiled DPDK Luca Vizzarro
2024-10-25 18:29 ` Dean Marx
2024-10-29 11:43 ` Luca Vizzarro
2024-10-29 15:48 ` Dean Marx
2024-10-29 19:52 ` Dean Marx
2024-10-29 21:12 ` Luca Vizzarro
2024-10-29 1:19 ` Patrick Robb [this message]
2024-10-29 11:48 ` Luca Vizzarro
2024-10-29 19:59 ` Patrick Robb
2024-10-21 13:49 ` [PATCH v2 6/7] doc: update argument options for external DPDK build Luca Vizzarro
2024-10-25 18:30 ` Dean Marx
2024-10-29 1:23 ` Patrick Robb
2024-10-29 12:35 ` Luca Vizzarro
2024-10-29 20:04 ` Patrick Robb
2024-10-21 13:49 ` [PATCH v2 7/7] dts: remove git ref option Luca Vizzarro
2024-10-25 18:31 ` Dean Marx
2024-10-29 1:28 ` Patrick Robb
2024-10-29 11:51 ` Luca Vizzarro
2024-10-21 22:39 ` [PATCH v2 0/7] DTS external DPDK build Dean Marx
2024-10-22 7:27 ` Paul Szczepanek
2024-10-22 14:56 ` Luca Vizzarro
2024-10-24 17:14 ` Dean Marx
2024-10-21 22:46 ` [PATCH v3 " Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 1/7] dts: rename build target to " Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 2/7] dts: enforce one dpdk build per test run Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 3/7] dts: change remote and local paths objects Luca Vizzarro
2024-10-25 18:10 ` Dean Marx
2024-10-29 1:29 ` Patrick Robb
2024-10-21 22:46 ` [PATCH v3 4/7] dts: enable copying directories to and from nodes Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 5/7] dts: add support for externally compiled DPDK Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 6/7] doc: update argument options for external DPDK build Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 7/7] dts: remove git ref option Luca Vizzarro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJvnSUBBTVG0pj-fjLdATRJUztTUYaGkOy9YfVREhbZP7WG+Kw@mail.gmail.com \
--to=probb@iol.unh.edu \
--cc=dev@dpdk.org \
--cc=luca.vizzarro@arm.com \
--cc=paul.szczepanek@arm.com \
--cc=tomas.durovec@pantheon.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).