From: Patrick Robb <probb@iol.unh.edu>
To: Jie Hai <haijie1@huawei.com>
Cc: dev@dpdk.org, Yisen Zhuang <yisen.zhuang@huawei.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
lihuisong@huawei.com, fengchengwen@huawei.com,
liuyonglong@huawei.com, huangdengdui@huawei.com
Subject: Re: [PATCH 1/5] net/hns3: fix offload flag of IEEE 1588
Date: Fri, 5 Apr 2024 10:33:34 -0400 [thread overview]
Message-ID: <CAJvnSUBi4Dviov0NrqxayVh1BiSMvc-+JPOuWAfhikJS=ZNGhw@mail.gmail.com> (raw)
In-Reply-To: <20240403101624.2771140-2-haijie1@huawei.com>
Recheck-request: iol-intel-Functional, iol-intel-Performance
On Wed, Apr 3, 2024 at 6:21 AM Jie Hai <haijie1@huawei.com> wrote:
>
> From: Dengdui Huang <huangdengdui@huawei.com>
>
> Currently, the RTE_MBUF_F_RX_IEEE1588_TMST offload flag will
> not be set when the scatter algorithm is used.
> This patch fixes it.
>
> Fixes: 4801f0403b58 ("net/hns3: fix IEEE 1588 PTP for scalar scattered Rx")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
> Signed-off-by: Jie Hai <haijie1@huawei.com>
> ---
> drivers/net/hns3/hns3_rxtx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c
> index 7e636a0a2e99..3e7dd1057940 100644
> --- a/drivers/net/hns3/hns3_rxtx.c
> +++ b/drivers/net/hns3/hns3_rxtx.c
> @@ -2669,6 +2669,7 @@ hns3_recv_scattered_pkts(void *rx_queue,
> continue;
> }
>
> + first_seg->ol_flags = 0;
> if (unlikely(bd_base_info & BIT(HNS3_RXD_TS_VLD_B)))
> hns3_rx_ptp_timestamp_handle(rxq, first_seg, timestamp);
>
> @@ -2698,7 +2699,7 @@ hns3_recv_scattered_pkts(void *rx_queue,
>
> first_seg->port = rxq->port_id;
> first_seg->hash.rss = rte_le_to_cpu_32(rxd.rx.rss_hash);
> - first_seg->ol_flags = RTE_MBUF_F_RX_RSS_HASH;
> + first_seg->ol_flags |= RTE_MBUF_F_RX_RSS_HASH;
> if (unlikely(bd_base_info & BIT(HNS3_RXD_LUM_B))) {
> first_seg->hash.fdir.hi =
> rte_le_to_cpu_16(rxd.rx.fd_id);
> --
> 2.30.0
>
next prev parent reply other threads:[~2024-04-05 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 10:16 [PATCH 0/5] net/hns3: add some bugfix Jie Hai
2024-04-03 10:16 ` [PATCH 1/5] net/hns3: fix offload flag of IEEE 1588 Jie Hai
2024-04-05 14:33 ` Patrick Robb [this message]
2024-04-03 10:16 ` [PATCH 2/5] net/hns3: fix read Rx timestamp handle Jie Hai
2024-04-03 10:16 ` [PATCH 3/5] net/hns3: fix double free for Rx/Tx queue Jie Hai
2024-04-03 10:16 ` [PATCH 4/5] net/hns3: fix variable overflow Jie Hai
2024-04-03 10:16 ` [PATCH 5/5] net/hns3: disable SCTP verification Tag for RSS hash input Jie Hai
2024-04-18 22:57 ` [PATCH 0/5] net/hns3: add some bugfix Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJvnSUBi4Dviov0NrqxayVh1BiSMvc-+JPOuWAfhikJS=ZNGhw@mail.gmail.com' \
--to=probb@iol.unh.edu \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=haijie1@huawei.com \
--cc=huangdengdui@huawei.com \
--cc=humin29@huawei.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).