From: Patrick Robb <probb@iol.unh.edu>
To: Luca Vizzarro <luca.vizzarro@arm.com>
Cc: dev@dpdk.org, "Paul Szczepanek" <paul.szczepanek@arm.com>,
"Tomáš Ďurovec" <tomas.durovec@pantheon.tech>
Subject: Re: [PATCH v2 7/7] dts: remove git ref option
Date: Mon, 28 Oct 2024 21:28:05 -0400 [thread overview]
Message-ID: <CAJvnSUD99eEE6w4AaDN4QHRG95YJHQ3mwTmXNQE+OnjqQaY0ag@mail.gmail.com> (raw)
In-Reply-To: <20241021134935.1210500-8-luca.vizzarro@arm.com>
[-- Attachment #1: Type: text/plain, Size: 2348 bytes --]
On Mon, Oct 21, 2024 at 9:50 AM Luca Vizzarro <luca.vizzarro@arm.com> wrote:
> From: Tomáš Ďurovec <tomas.durovec@pantheon.tech>
>
> Given the whole DPDK tree directory can now be copied to the nodes,
> there is no more need to use the git ref option, as the tree can be
> controlled directly by the user.
>
> Signed-off-by: Tomáš Ďurovec <tomas.durovec@pantheon.tech>
> Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
> ---
> doc/guides/tools/dts.rst | 9 ---
> dts/framework/settings.py | 48 ++-------------
> dts/framework/utils.py | 119 +-------------------------------------
> 3 files changed, 7 insertions(+), 169 deletions(-)
>
> diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst
> index 7b90c4856e..a00d987ece 100644
> --- a/doc/guides/tools/dts.rst
> +++ b/doc/guides/tools/dts.rst
> @@ -237,9 +237,6 @@ DTS is run with ``main.py`` located in the ``dts``
> directory after entering Poet
> -t SECONDS, --timeout SECONDS
> [DTS_TIMEOUT] The default timeout for all DTS
> operations except for compiling DPDK. (default: 15)
> -v, --verbose [DTS_VERBOSE] Specify to enable verbose
> output, logging all messages to the console. (default: False)
> - --revision ID, --rev ID, --git-ref ID
> - [DTS_DPDK_REVISION_ID] Git revision ID to
> test. Could be commit, tag, tree ID etc. To test local changes, first
> - commit them, then use their commit ID.
> (default: None)
> --compile-timeout SECONDS
> [DTS_COMPILE_TIMEOUT] The timeout for
> compiling DPDK. (default: 1200)
> --test-suite TEST_SUITE [TEST_CASES ...]
> @@ -275,12 +272,6 @@ The minimum DTS needs is a config file and a
> pre-built DPDK or DPDK
> sources location which can be specified in said config file or on the
> command line or environment variables.
>
> -Example command for running DTS with the template configuration and DPDK
> tag v23.11:
> -
> -.. code-block:: console
> -
> - (dts-py3.10) $ ./main.py --git-ref v23.11
> -
>
I see this needs to go because of the --git-ref usage. Can this be replaced
with a new example command? Perhaps even 2, one for each of --tarball and
--dpdk-tree?
Reviewed-by: Patrick Robb <probb@iol.unh.edu>
[-- Attachment #2: Type: text/html, Size: 2968 bytes --]
next prev parent reply other threads:[~2024-10-29 1:29 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 16:01 [PATCH 0/7] DTS external DPDK build Tomáš Ďurovec
2024-09-30 16:01 ` [PATCH 1/7] dts: rename build target to " Tomáš Ďurovec
2024-09-30 16:01 ` [PATCH 2/7] dts: one dpdk build per test run Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 3/7] dts: fix remote session file transfer vars Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 4/7] dts: add the ability to copy directories via remote Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 5/7] dts: add support for externally compiled DPDK Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 6/7] doc: update argument options for external DPDK build Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 7/7] dts: remove git ref option Tomáš Ďurovec
2024-10-21 13:49 ` [PATCH v2 0/7] DTS external DPDK build Luca Vizzarro
2024-10-21 13:49 ` [PATCH v2 1/7] dts: rename build target to " Luca Vizzarro
2024-10-25 18:05 ` Dean Marx
2024-10-29 1:29 ` Patrick Robb
2024-10-21 13:49 ` [PATCH v2 2/7] dts: enforce one dpdk build per test run Luca Vizzarro
2024-10-25 18:08 ` Dean Marx
2024-10-29 1:29 ` Patrick Robb
2024-10-21 13:49 ` [PATCH v2 3/7] dts: fix remote session file transfer vars Luca Vizzarro
2024-10-21 13:49 ` [PATCH v2 4/7] dts: enable copying directories to and from nodes Luca Vizzarro
2024-10-25 18:12 ` Dean Marx
2024-10-29 1:07 ` Patrick Robb
2024-10-29 12:00 ` Luca Vizzarro
2024-10-21 13:49 ` [PATCH v2 5/7] dts: add support for externally compiled DPDK Luca Vizzarro
2024-10-25 18:29 ` Dean Marx
2024-10-29 11:43 ` Luca Vizzarro
2024-10-29 15:48 ` Dean Marx
2024-10-29 19:52 ` Dean Marx
2024-10-29 21:12 ` Luca Vizzarro
2024-10-29 1:19 ` Patrick Robb
2024-10-29 11:48 ` Luca Vizzarro
2024-10-29 19:59 ` Patrick Robb
2024-10-21 13:49 ` [PATCH v2 6/7] doc: update argument options for external DPDK build Luca Vizzarro
2024-10-25 18:30 ` Dean Marx
2024-10-29 1:23 ` Patrick Robb
2024-10-29 12:35 ` Luca Vizzarro
2024-10-29 20:04 ` Patrick Robb
2024-10-21 13:49 ` [PATCH v2 7/7] dts: remove git ref option Luca Vizzarro
2024-10-25 18:31 ` Dean Marx
2024-10-29 1:28 ` Patrick Robb [this message]
2024-10-29 11:51 ` Luca Vizzarro
2024-10-21 22:39 ` [PATCH v2 0/7] DTS external DPDK build Dean Marx
2024-10-22 7:27 ` Paul Szczepanek
2024-10-22 14:56 ` Luca Vizzarro
2024-10-24 17:14 ` Dean Marx
2024-10-21 22:46 ` [PATCH v3 " Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 1/7] dts: rename build target to " Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 2/7] dts: enforce one dpdk build per test run Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 3/7] dts: change remote and local paths objects Luca Vizzarro
2024-10-25 18:10 ` Dean Marx
2024-10-29 1:29 ` Patrick Robb
2024-10-21 22:46 ` [PATCH v3 4/7] dts: enable copying directories to and from nodes Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 5/7] dts: add support for externally compiled DPDK Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 6/7] doc: update argument options for external DPDK build Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 7/7] dts: remove git ref option Luca Vizzarro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJvnSUD99eEE6w4AaDN4QHRG95YJHQ3mwTmXNQE+OnjqQaY0ag@mail.gmail.com \
--to=probb@iol.unh.edu \
--cc=dev@dpdk.org \
--cc=luca.vizzarro@arm.com \
--cc=paul.szczepanek@arm.com \
--cc=tomas.durovec@pantheon.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).