From: Patrick Robb <probb@iol.unh.edu>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Chengwen Feng" <fengchengwen@huawei.com>,
"Honnappa Nagarahalli" <honnappa.nagarahalli@arm.com>,
"Kevin Laatz" <kevin.laatz@intel.com>,
"Srikanth Yalavarthi" <syalavarthi@marvell.com>,
"Vladimir Medvedkin" <vladimir.medvedkin@intel.com>
Subject: Re: [PATCH v2] build: exclude rather than include libs in MSVC build
Date: Fri, 5 Apr 2024 20:38:31 -0400 [thread overview]
Message-ID: <CAJvnSUDDrkD+kATcx4X+mo8BRY-_4jZWtN=s79mywgQjC650wA@mail.gmail.com> (raw)
In-Reply-To: <1712168600-17289-1-git-send-email-roretzla@linux.microsoft.com>
Recheck-request: iol-intel-Functional
Replied to the wrong version before
On Wed, Apr 3, 2024 at 2:23 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> Some libraries that could be built with MSVC were not being built.
>
> Switch from explicit include to exclude of libs to get immediate CI
> coverage of libraries that already work with MSVC Windows builds.
>
> With this change we now get immediate CI build coverage for the libs
> meter, timer, pci, cfgfile
>
> v2:
> * add a few more explicit exclusions for now as they are known to require
> more than trivial work and avoid needing to disable them later as the
> dependent libraries are enabled.
>
> Tyler Retzlaff (1):
> build: exclude rather than include libs in MSVC build
>
> lib/argparse/meson.build | 6 ++++++
> lib/dmadev/meson.build | 6 ++++++
> lib/fib/meson.build | 6 ++++++
> lib/lpm/meson.build | 6 ++++++
> lib/mbuf/meson.build | 6 ++++++
> lib/mempool/meson.build | 6 ++++++
> lib/meson.build | 10 ----------
> lib/mldev/meson.build | 6 ++++++
> lib/rcu/meson.build | 6 ++++++
> lib/stack/meson.build | 6 ++++++
> 10 files changed, 54 insertions(+), 10 deletions(-)
>
> --
> 1.8.3.1
>
prev parent reply other threads:[~2024-04-06 0:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 16:55 [PATCH] " Tyler Retzlaff
2024-04-02 16:55 ` Tyler Retzlaff
2024-04-02 17:15 ` Stephen Hemminger
2024-04-02 17:19 ` Tyler Retzlaff
2024-04-05 20:33 ` Patrick Robb
2024-04-03 18:23 ` [PATCH v2] " Tyler Retzlaff
2024-04-03 18:23 ` Tyler Retzlaff
2024-04-03 18:50 ` Morten Brørup
2024-04-11 5:01 ` Patrick Robb
2024-04-03 21:51 ` Stephen Hemminger
2024-04-05 14:29 ` Patrick Robb
2024-04-06 0:38 ` Patrick Robb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJvnSUDDrkD+kATcx4X+mo8BRY-_4jZWtN=s79mywgQjC650wA@mail.gmail.com' \
--to=probb@iol.unh.edu \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=kevin.laatz@intel.com \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
--cc=syalavarthi@marvell.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).