From: Patrick Robb <probb@iol.unh.edu>
To: Andrew Bailey <abailey@iol.unh.edu>
Cc: luca.vizzarro@arm.com, dev@dpdk.org, dmarx@iol.unh.edu,
ivan.malov@arknetworks.am
Subject: Re: [PATCH v4 3/3] dts: update tx_offload test from old dts
Date: Wed, 24 Sep 2025 16:53:32 -0400 [thread overview]
Message-ID: <CAJvnSUDPpfr_AqQM5wtf2WSG5j6v6auXbHYx3DHyiZ12C51gSg@mail.gmail.com> (raw)
In-Reply-To: <20250924164725.168773-4-abailey@iol.unh.edu>
[-- Attachment #1: Type: text/plain, Size: 7399 bytes --]
On Wed, Sep 24, 2025 at 12:47 PM Andrew Bailey <abailey@iol.unh.edu> wrote:
> Currently, the RX/TX offload test in old DTS expects the TX ports to be
> initially configured to use mbuf fast free. This is no longer the case
> and must be updated to assume mbuf fast free is not initially utilized
> by capable NICs. Add updated test suite to test mbuf fast free
> configuration.
>
> Signed-off-by: Andrew Bailey <abailey@iol.unh.edu>
> ---
> doc/api/dts/tests.TestSuite_rx_tx_offload.rst | 8 ++
> dts/tests/TestSuite_rx_tx_offload.py | 128 ++++++++++++++++++
> 2 files changed, 136 insertions(+)
> create mode 100644 doc/api/dts/tests.TestSuite_rx_tx_offload.rst
> create mode 100644 dts/tests/TestSuite_rx_tx_offload.py
>
> diff --git a/doc/api/dts/tests.TestSuite_rx_tx_offload.rst
> b/doc/api/dts/tests.TestSuite_rx_tx_offload.rst
> new file mode 100644
> index 0000000000..225267a45f
> --- /dev/null
> +++ b/doc/api/dts/tests.TestSuite_rx_tx_offload.rst
> @@ -0,0 +1,8 @@
> +.. SPDX-License-Identifier: BSD-3-Clause
> +
> +rx_tx_offload Test Suite
> +=========================
>
Did you try to build the docs after adding this file? I might be wrong but
I think the syntax might be flawed. If you don't remember the docs build
process is:
meson setup build
ninja -C build doc
> +
> +.. automodule:: tests.TestSuite_rx_tx_offload
> + :members:
> + :show-inheritance:
> \ No newline at end of file
> diff --git a/dts/tests/TestSuite_rx_tx_offload.py
> b/dts/tests/TestSuite_rx_tx_offload.py
> new file mode 100644
> index 0000000000..6ae98068e4
> --- /dev/null
> +++ b/dts/tests/TestSuite_rx_tx_offload.py
> @@ -0,0 +1,128 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2025 University of New Hampshire
> +
> +"""RX TX offload test suite.
> +
> +Test the testpmd feature of configuring RX and TX offloads.
> +"""
> +
> +from framework.remote_session.testpmd_shell import (
> + OffloadConfiguration,
> + RxTxLiteralSwitch,
> + TestPmdShell,
> +)
>
your branch needs to be rebased off of dpdk-next-dts/for-main. We have
merged Paul's DTS API patch, which means your imports are no longer valid
and will need to be updated.
> +from framework.test_suite import TestSuite, func_test
> +from framework.testbed_model.capability import NicCapability, requires
> +
> +
> +class TestRxTxOffload(TestSuite):
> + """RX/TX offload test suite."""
> +
> + def _check_config(
> + self,
> + testpmd: TestPmdShell,
> + port_offload: str | None,
> + rxtx: RxTxLiteralSwitch,
> + port_id: int,
> + /,
> + queue_offload: list[str | None] | None = None,
> + verify: bool = True,
> + ) -> bool:
> + config: OffloadConfiguration = testpmd.get_offload_config(rxtx,
> port_id, verify)
> + if config.port.name != port_offload:
> + return False
> +
> + if queue_offload:
> + for i, q in enumerate(config.queues):
> + if q.name != queue_offload[i]:
> + return False
> + return True
> +
> + def _set_all_queues_mbuf_fast_free(
> + self, testpmd: TestPmdShell, on: bool, port_id: int, num_queues:
> int, /, verify: bool = True
> + ) -> None:
> + for i in range(num_queues):
> + testpmd.set_queue_mbuf_fast_free(on, port_id, i, verify)
> +
> + @requires(NicCapability.PORT_TX_OFFLOAD_MBUF_FAST_FREE)
> + @func_test
> + def test_mbuf_fast_free_configuration_per_port(self) -> None:
> + """Ensure mbuf_fast_free can be configured with testpmd per port.
> +
> + Steps:
> + * Start up testpmd shell.
> + * Toggle mbuf_fast_free on per port.
> + * Toggle mbuf_fast_free off per port.
> +
> + Verify:
> + * Mbuf_fast_free starts disabled.
> + * Mbuf_fast_free can be configured on per port.
> + * Mbuf_fast_free can be configured off per port.
> + """
> + with TestPmdShell() as testpmd:
> + verify = True
> + port_id = 0
> + testpmd.start_all_ports()
> +
> + # Ensure MBUF_FAST_FREE is disabled by default and verify
> + self.verify(
> + self._check_config(testpmd, None, "tx", port_id,
> verify=verify),
> + "MBUF_FAST_FREE enabled on port start.",
> + )
> + # Enable MBUF_FAST_FREE per port and verify
> + testpmd.set_port_mbuf_fast_free(True, port_id, verify)
> + self.verify(
> + self._check_config(
> + testpmd, "TX_OFFLOAD_MBUF_FAST_FREE", "tx", port_id,
> verify=verify
> + ),
> + "Failed to enable MBUF_FAST_FREE on port.",
> + )
> + # Disable MBUF_FAST_FREE per port and verify
> + testpmd.set_port_mbuf_fast_free(False, port_id, verify)
> + self.verify(
> + self._check_config(testpmd, None, "tx", port_id,
> verify=verify),
> + "Failed to disable MBUF_FAST_FREE on port.",
> + )
> +
> + @requires(NicCapability.QUEUE_TX_OFFLOAD_MBUF_FAST_FREE)
> + @func_test
> + def test_mbuf_fast_free_configuration_per_queue(self) -> None:
> + """Ensure mbuf_fast_free can be configured with testpmd.
> +
> + Steps:
> + * Start up testpmd shell.
> + * Toggle mbuf_fast_free on per queue.
> + * Toggle mbuf_fast_free off per queue.
> +
> + Verify:
> + * Mbuf_fast_free starts disabled.
> + * Mbuf_fast_free can be configured on per queue.
> + * Mbuf_fast_free can be configured off per queue.
> + """
> + with TestPmdShell() as testpmd:
> + verify = True
> + port_id = 0
> + num_queues = 4
> + queue_off: list[str | None] | None = [None] * num_queues
> + queue_on: list[str | None] | None =
> ["TX_OFFLOAD_MBUF_FAST_FREE"] * num_queues
> +
> + testpmd.set_ports_queues(num_queues)
> + testpmd.start_all_ports()
> +
> + # Ensure mbuf_fast_free is disabled by default on port and
> queues
> + self.verify(
> + self._check_config(testpmd, None, "tx", port_id,
> queue_off, verify=verify),
> + "MBUF_FAST_FREE enabled on queue start.",
> + )
> + # Enable mbuf_fast_free per queue and verify
> + self._set_all_queues_mbuf_fast_free(testpmd, True, port_id,
> num_queues, verify)
> + self.verify(
> + self._check_config(testpmd, None, "tx", port_id,
> queue_on, verify),
> + "Failed to enable MBUF_FAST_FREE on all queues.",
> + )
> + # Disable mbuf_fast_free per queue and verify
> + self._set_all_queues_mbuf_fast_free(testpmd, False, port_id,
> num_queues, verify)
> + self.verify(
> + self._check_config(testpmd, None, "tx", port_id,
> queue_off, verify),
> + "Failed to disable MBUF_FAST_FREE on all queues.",
> + )
> --
> 2.50.1
>
>
Let's look at the testcases themselves together tomorrow or Friday. Thanks
Andrew.
[-- Attachment #2: Type: text/html, Size: 9435 bytes --]
prev parent reply other threads:[~2025-09-24 20:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 11:43 [PATCH v1 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-09-02 11:43 ` [PATCH v1 1/3] dts: fix docstring typo in checksum suite Andrew Bailey
2025-09-02 11:43 ` [PATCH v1 2/3] dts: add reception check to checksum offload suite Andrew Bailey
2025-09-02 11:43 ` [PATCH v1 3/3] dts: all are one Andrew Bailey
2025-09-02 11:48 ` [PATCH v1 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-09-24 16:47 ` [PATCH v4 0/3] dts:add " Andrew Bailey
2025-09-24 16:47 ` [PATCH v4 1/3] dts: allow mbuf_fast_free to be set with testpmd shell Andrew Bailey
2025-09-24 20:51 ` Patrick Robb
2025-09-25 16:01 ` Luca Vizzarro
2025-09-24 16:47 ` [PATCH v4 2/3] dts: add TX offload capabilities to NIC capabilities Andrew Bailey
2025-09-24 20:51 ` Patrick Robb
2025-09-25 16:05 ` Luca Vizzarro
2025-09-24 16:47 ` [PATCH v4 3/3] dts: update tx_offload test from old dts Andrew Bailey
2025-09-24 20:53 ` Patrick Robb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJvnSUDPpfr_AqQM5wtf2WSG5j6v6auXbHYx3DHyiZ12C51gSg@mail.gmail.com \
--to=probb@iol.unh.edu \
--cc=abailey@iol.unh.edu \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=ivan.malov@arknetworks.am \
--cc=luca.vizzarro@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).