From: Keunhong Lee <dlrmsghd@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/2] Native uio-based PMD for Mellanox ConnectX-3 devices
Date: Tue, 7 Jul 2015 00:57:43 +0900 [thread overview]
Message-ID: <CAKBXKmDzGA=FQ-7-xxgCHy9ODWui1Qnxy7sbmDFqW7hcGzXv8A@mail.gmail.com> (raw)
In-Reply-To: <3865893.mD3C20oiXL@xps13>
Answer 1. UIO based driver is faster then ib based driver.
It can saturate 40G link with MTU sized packets using a single thread while
ib wrapper cannot.
Answer 2. Sorry, I missed that. I'll make a new patch email with my real
name.
Question 1. Is it OK if I separate GPL-based and BSD-based codes into
separated patches?
mlx4 kernel driver itself is dual licenses, so I think they are considered
as BSD
in my source code.
The only source code under GPL is bitmap, integer logarithm, and red-black
tree
contained in mlnx_uio/kernel directory.
Keunhong.
2015-07-06 23:17 GMT+09:00 Thomas Monjalon <thomas.monjalon@6wind.com>:
> 2015-07-06 22:28, leeopop:
> > This is a native UIO-based PMD for Mellanox ConnectX-3 devices.
> > It uses a persistent memory library in order to provide a persistent
> > scartch area for the mlx4 HCA driver.
>
> What is the benefit of this UIO approach compared to the OFED based driver?
>
> > We release the driver itself under BSD license, but to use it for
> > commercial products, you may have to re-implement the separated GPL
> sources.
>
> The GPL sources are not really separated.
> The DPDK libraries must be BSD-licensed.
>
> > The GPL affected source codes reside in the mlnx_uio/kernel directory.
>
> It seems that a large part of the GPL driver was also copied in
> mlnx_uio/mlnx/.
>
> Given that you are dropping a huge GPL codebase (whose you don't own the
> copyright)
> in a BSD library, and that you didn't give your real name in the
> signed-off line,
> it is NACK.
>
next prev parent reply other threads:[~2015-07-06 15:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 13:28 leeopop
2015-07-06 13:28 ` [dpdk-dev] [PATCH 1/2] eal/persistent: new library to hold memory region after program exit leeopop
2015-07-06 14:34 ` Avi Kivity
2015-07-06 14:41 ` Thomas Monjalon
2015-07-06 19:19 ` Stephen Hemminger
2015-07-06 13:28 ` [dpdk-dev] [PATCH 2/2] mlnx_uio: new poll mode driver leeopop
2015-07-06 14:17 ` [dpdk-dev] [PATCH 0/2] Native uio-based PMD for Mellanox ConnectX-3 devices Thomas Monjalon
2015-07-06 15:57 ` Keunhong Lee [this message]
2015-07-06 16:14 ` Thomas Monjalon
2015-07-06 17:55 ` Keunhong Lee
2015-07-07 6:50 ` Olga Shern
2015-07-07 7:02 ` Pavel Odintsov
2015-07-07 9:18 ` Olga Shern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKBXKmDzGA=FQ-7-xxgCHy9ODWui1Qnxy7sbmDFqW7hcGzXv8A@mail.gmail.com' \
--to=dlrmsghd@gmail.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).