From: Francesco <francesco.montorsi@gmail.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Add error message when trying to use make option T= during build/clean
Date: Wed, 14 Oct 2015 10:02:43 +0200 [thread overview]
Message-ID: <CAKW0qihdPfKdf5e4p9GoBUeGXwjFxQ=j3xLnC9F7_4zDtr529Q@mail.gmail.com> (raw)
In-Reply-To: <561D05A4.2060708@6wind.com>
Hi Olivier,
thanks for reviewing the patch. However for me it is logical that T= option
is used for "config" target and then for building/cleaning only O= is used.
However it is not logical for me that install target requires T= option
instead of O= option... or perhaps I'm missing something?
Thanks,
Francesco
2015-10-13 15:22 GMT+02:00 Olivier MATZ <olivier.matz@6wind.com>:
> Hi Francesco,
>
> On 09/29/2015 06:04 PM, Francesco Montorsi wrote:
> > From: Francesco Montorsi <fmontorsi@empirix.com>
> >
> > ---
> > mk/rte.sdkbuild.mk | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
> > index 38ec7bd..013aa89 100644
> > --- a/mk/rte.sdkbuild.mk
> > +++ b/mk/rte.sdkbuild.mk
> > @@ -29,6 +29,12 @@
> > # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
> USE
> > # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> >
> > +ifdef T
> > + ifeq ("$(origin T)", "command line")
> > + $(error "Cannot use T= with a build/clean target")
> > + endif
> > +endif
> > +
> > # If DESTDIR variable is given, install binary dpdk
>
> I tested this patch but it breaks the "make install" command:
>
> $ make install T=x86_64-native-linuxapp-gcc
> make[5]: Nothing to be done for 'depdirs'.
> Configuration done
> rte.sdkbuild.mk:34: *** "Cannot use T= with a build/clean target".
>
> As the T= argument is given as a command line variable, it is
> propagated to the "$(MAKE) all" in rte.sdkinstall.mk.
> So I think it's better to keep the current code as is, except if
> you have a better idea.
>
> Regards,
> Olivier
>
next prev parent reply other threads:[~2015-10-14 8:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 16:04 Francesco Montorsi
2015-10-13 13:22 ` Olivier MATZ
2015-10-14 8:02 ` Francesco [this message]
2015-10-21 19:27 ` Olivier MATZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKW0qihdPfKdf5e4p9GoBUeGXwjFxQ=j3xLnC9F7_4zDtr529Q@mail.gmail.com' \
--to=francesco.montorsi@gmail.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).