From: Jerin Jacob <jerinjacobk@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Pavan Nikhilesh <pbhagavatula@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Jay Jayatheerthan <jay.jayatheerthan@intel.com>,
dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eventdev: fix signed comparison
Date: Wed, 14 Apr 2021 12:22:07 +0530 [thread overview]
Message-ID: <CALBAE1M-edYX7ghtVzs9DkNqxeLYyEL+g4aPC-zfEYMRKPuNwg@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8zHxKKDJ5HHobYq6hPHwkN-wZJwm=FUN5fMQtz3uTaXxA@mail.gmail.com>
On Wed, Apr 14, 2021 at 11:56 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Wed, Apr 14, 2021 at 12:16 AM <pbhagavatula@marvell.com> wrote:
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Since queue identifier is passed as signed integer, a compilation error
> > is generated:
> > rte_event_eth_rx_adapter.c:1810:57: error: signed and unsigned type
> > in conditional expression [-Werror=sign-compare]
> > Make queue identifier as unsigned when adding it to vector data.
> >
>
> Bugzilla ID: 672
>
> > Fixes: d7c428e557ba ("eventdev: support Rx adapter event vector")
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> LGTM and fixes compilation for RHEL7.
>
> Acked-by: David Marchand <david.marchand@redhat.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
>
> Jerin, do you mind if I take it directly in main?
Yes . Please
>
>
> --
> David Marchand
>
next prev parent reply other threads:[~2021-04-14 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 22:16 pbhagavatula
2021-04-14 6:26 ` David Marchand
2021-04-14 6:52 ` Jerin Jacob [this message]
2021-04-14 8:06 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1M-edYX7ghtVzs9DkNqxeLYyEL+g4aPC-zfEYMRKPuNwg@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).