From: Jerin Jacob <jerinjacobk@gmail.com>
To: Anoob Joseph <anoobj@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Narayana Prasad <pathreya@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix exit paths after cq init
Date: Fri, 15 Nov 2019 13:02:37 +0530 [thread overview]
Message-ID: <CALBAE1M0AW0G_p_P1towK_8YuuM4UnXnMp+OrFeXd1TU5+EOVA@mail.gmail.com> (raw)
In-Reply-To: <1573478474-17984-1-git-send-email-anoobj@marvell.com>
On Mon, Nov 11, 2019 at 6:51 PM Anoob Joseph <anoobj@marvell.com> wrote:
>
> After otx2_nix_register_cq_irqs() is called and the IRQs are setup,
> otx2_nix_unregister_cq_irqs() need to be called in the subsequent error
> exit paths.
>
> Fixes: d34db5ccbf30 ("net/octeontx2: fix driver reconfiguration")
>
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/master. Thanks
> ---
> drivers/net/octeontx2/otx2_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c
> index aab34db..18aa0f5 100644
> --- a/drivers/net/octeontx2/otx2_ethdev.c
> +++ b/drivers/net/octeontx2/otx2_ethdev.c
> @@ -1700,13 +1700,13 @@ otx2_nix_configure(struct rte_eth_dev *eth_dev)
> rc = cgx_intlbk_enable(dev, eth_dev->data->dev_conf.lpbk_mode);
> if (rc) {
> otx2_err("Failed to configure cgx loop back mode rc=%d", rc);
> - goto q_irq_fini;
> + goto cq_fini;
> }
>
> rc = otx2_nix_rxchan_bpid_cfg(eth_dev, true);
> if (rc) {
> otx2_err("Failed to configure nix rx chan bpid cfg rc=%d", rc);
> - goto q_irq_fini;
> + goto cq_fini;
> }
>
> rc = otx2_nix_mc_addr_list_install(eth_dev);
> --
> 2.7.4
>
prev parent reply other threads:[~2019-11-15 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 13:21 Anoob Joseph
2019-11-15 7:32 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1M0AW0G_p_P1towK_8YuuM4UnXnMp+OrFeXd1TU5+EOVA@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=anoobj@marvell.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=pathreya@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).