From: Jerin Jacob <jerinjacobk@gmail.com>
To: Ruifeng Wang <ruifeng.wang@arm.com>
Cc: Jerin Jacob <jerinj@marvell.com>, Gavin Hu <gavin.hu@arm.com>,
dpdk-dev <dev@dpdk.org>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
nd <nd@arm.com>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] lib/bpf: fix clang build warnings for aarch64
Date: Fri, 15 Nov 2019 09:15:04 +0530 [thread overview]
Message-ID: <CALBAE1M6n3xaUU-_2Vcf+hSOWeSDpKKYSH7Z9J-2v3VPVcwL2w@mail.gmail.com> (raw)
In-Reply-To: <20191115031801.83730-1-ruifeng.wang@arm.com>
On Fri, Nov 15, 2019 at 8:48 AM Ruifeng Wang <ruifeng.wang@arm.com> wrote:
>
> Couple of warnings will block build when warnings been treated as errors.
> Clang version 8.0 was used.
>
> Warning messages during build:
> ../lib/librte_bpf/bpf_jit_arm64.c:1438:26: warning: incompatible pointer
> types passing 'uint32_t *' (aka 'unsigned int *') to parameter of type
> 'char *' [-Wincompatible-pointer-types]
> __builtin___clear_cache(ctx.ins, ctx.ins + ctx.idx);
> ^~~~~~~
> ../lib/librte_bpf/bpf_jit_arm64.c:1438:35: warning: incompatible pointer
> types passing 'uint32_t *' (aka 'unsigned int *') to parameter of type
> 'char *' [-Wincompatible-pointer-types]
> __builtin___clear_cache(ctx.ins, ctx.ins + ctx.idx);
> ^~~~~~~~~~~~~~~~~
>
> Fixes: f3e516772464 ("bpf/arm: add prologue and epilogue")
> Cc: stable@dpdk.org
No need to CC stable as this has been added in this release.
Is clang prototype for __builtin___clear_cache() different? If so,
update the git commit for the reason for the failure.
in gcc[1], it is void *.
[1]
void __builtin___clear_cache (void *begin, void *end)
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
prev parent reply other threads:[~2019-11-15 3:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 3:18 [dpdk-stable] " Ruifeng Wang
2019-11-15 3:45 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1M6n3xaUU-_2Vcf+hSOWeSDpKKYSH7Z9J-2v3VPVcwL2w@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).