From: Jerin Jacob <jerinjacobk@gmail.com>
To: Vamsi Attunuru <vattunuru@marvell.com>
Cc: dev@dpdk.org, jerinj@marvell.com, sthotton@marvell.com
Subject: Re: [PATCH v4 3/3] net/octeon_ep: add new fastpath routines
Date: Wed, 18 Oct 2023 09:18:41 +0530 [thread overview]
Message-ID: <CALBAE1MF67LwiotkSWLduU4fPpnHcxdQKaDH1UKEAqFGu2CNJA@mail.gmail.com> (raw)
In-Reply-To: <20231012062354.535392-4-vattunuru@marvell.com>
On Thu, Oct 12, 2023 at 4:41 PM Vamsi Attunuru <vattunuru@marvell.com> wrote:
>
> Adds new fastpath routines for cn10k & cn9k endpoint
> devices and assigns the fastpath routines based on
> the offload flags.
>
> Patch also adds misc changes to improve performance
> and code-readability.
>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Could you rebase to next-net-mrvl. There is build issue, either due to
latest clang or new changes in main.
[for-next-net][dpdk-next-net-mrvl] $ clang -v
clang version 16.0.6
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-pc-linux-gnu/13.2.1
Found candidate GCC installation:
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.2.1
Selected GCC installation: /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.2.1
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Selected multilib: .;@m64
ccache clang -Idrivers/libtmp_rte_net_octeon_ep.a.p -Idrivers
-I../drivers -Idrivers/net/octeon_ep -I../drivers/net/octeon_ep
-Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config
-Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/
include -I../lib/eal/linux/include -Ilib/eal/x86/include
-I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common
-Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log
-I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry
-I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf
-Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter
-I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci
-I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci
-Idrivers/bus/vdev -I../drivers/bus/vdev -fcolor-diagnostics
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11
-O2 -g -include rte_config.h -Wcast-qual -Wdeprecated -Wformat
-Wformat-nonliteral -Wformat-security -Wmissing-
declarations -Wmissing-prototypes -Wnested-externs
-Wold-style-definition -Wpointer-arith -Wsign-compare
-Wstrict-prototypes -Wundef -Wwrite-strings
-Wno-address-of-packed-member -Wno-missing-field-initializers
-D_GNU_SOURCE -fPIC -march=na
tive -mrtm -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API
-DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.octeon_ep -DRTE_ANNOTATE_LOCKS
-Wthread-safety -MD -MQ
drivers/libtmp_rte_net_octeon_ep.a.p/net_octeon_ep_otx_ep_rxtx.c.o -MF
drivers/libtmp_rte_net_
octeon_ep.a.p/net_octeon_ep_otx_ep_rxtx.c.o.d -o
drivers/libtmp_rte_net_octeon_ep.a.p/net_octeon_ep_otx_ep_rxtx.c.o -c
../drivers/net/octeon_ep/otx_ep_rxtx.c
../drivers/net/octeon_ep/otx_ep_rxtx.c:448:10: error: address argument
to atomic operation must be a pointer to _Atomic type ('uint32_t *'
(aka 'unsigned int *') invalid)
while (rte_atomic_load_explicit(iq->inst_cnt_ism,
rte_memory_order_relaxed) >=
^ ~~~~~~~~~~~~~~~~
../lib/eal/include/rte_stdatomic.h:71:2: note: expanded from macro
'rte_atomic_load_explicit'
atomic_load_explicit(ptr, memorder)
^ ~~~
/usr/lib/clang/16/include/stdatomic.h:134:30: note: expanded from
macro 'atomic_load_explicit'
#define atomic_load_explicit __c11_atomic_load
^
../drivers/net/octeon_ep/otx_ep_rxtx.c:924:10: error: address argument
to atomic operation must be a pointer to _Atomic type ('uint32_t *'
(aka 'unsigned int *') invalid)
while (rte_atomic_load_explicit(droq->pkts_sent_ism,
rte_memory_order_relaxed) >=
^ ~~~~~~~~~~~~~~~~~~~
../lib/eal/include/rte_stdatomic.h:71:2: note: expanded from macro
'rte_atomic_load_explicit'
atomic_load_explicit(ptr, memorder)
^ ~~~
/usr/lib/clang/16/include/stdatomic.h:134:30: note: expanded from
macro 'atomic_load_explicit'
#define atomic_load_explicit __c11_atomic_load
^
next prev parent reply other threads:[~2023-10-18 3:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 1:50 [PATCH 0/3] rewrite " Vamsi Attunuru
2023-10-11 1:50 ` [PATCH 1/3] net/octeon_ep: support 32B IQ descriptor size Vamsi Attunuru
2023-10-11 1:50 ` [PATCH 2/3] net/octeon_ep: clean up receive routine Vamsi Attunuru
2023-10-11 1:50 ` [PATCH 3/3] net/octeon_ep: add new fastpath routines Vamsi Attunuru
2023-10-11 8:36 ` [PATCH v2 0/3] rewrite " Vamsi Attunuru
2023-10-11 8:36 ` [PATCH v2 1/3] net/octeon_ep: support 32B IQ descriptor size Vamsi Attunuru
2023-10-11 8:36 ` [PATCH v2 2/3] net/octeon_ep: clean up receive routine Vamsi Attunuru
2023-10-11 8:36 ` [PATCH v2 3/3] net/octeon_ep: add new fastpath routines Vamsi Attunuru
2023-10-11 12:53 ` [PATCH v3 0/3] rewrite " Vamsi Attunuru
2023-10-11 12:53 ` [PATCH v3 1/3] net/octeon_ep: support 32B IQ descriptor size Vamsi Attunuru
2023-10-11 12:53 ` [PATCH v3 2/3] net/octeon_ep: clean up receive routine Vamsi Attunuru
2023-10-11 12:53 ` [PATCH v3 3/3] net/octeon_ep: add new fastpath routines Vamsi Attunuru
2023-10-12 6:23 ` [PATCH v4 0/3] rewrite " Vamsi Attunuru
2023-10-12 6:23 ` [PATCH v4 1/3] net/octeon_ep: support 32B IQ descriptor size Vamsi Attunuru
2023-10-12 6:23 ` [PATCH v4 2/3] net/octeon_ep: clean up receive routine Vamsi Attunuru
2023-10-12 6:23 ` [PATCH v4 3/3] net/octeon_ep: add new fastpath routines Vamsi Attunuru
2023-10-18 3:48 ` Jerin Jacob [this message]
2023-10-18 8:07 ` [PATCH v5 0/3] rewrite " Vamsi Attunuru
2023-10-18 8:07 ` [PATCH v5 1/3] net/octeon_ep: support 32B IQ descriptor size Vamsi Attunuru
2023-10-18 8:07 ` [PATCH v5 2/3] net/octeon_ep: clean up receive routine Vamsi Attunuru
2023-10-18 8:07 ` [PATCH v5 3/3] net/octeon_ep: add new fastpath routines Vamsi Attunuru
2023-10-18 11:14 ` [PATCH v6 0/3] rewrite " Vamsi Attunuru
2023-10-18 11:14 ` [PATCH v6 1/3] net/octeon_ep: support 32B IQ descriptor size Vamsi Attunuru
2023-10-18 11:14 ` [PATCH v6 2/3] net/octeon_ep: clean up receive routine Vamsi Attunuru
2023-10-18 11:14 ` [PATCH v6 3/3] net/octeon_ep: add new fastpath routines Vamsi Attunuru
2023-10-19 3:03 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1MF67LwiotkSWLduU4fPpnHcxdQKaDH1UKEAqFGu2CNJA@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=sthotton@marvell.com \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).