From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Cc: Srujana Challa <schalla@marvell.com>,
Shijith Thotton <sthotton@marvell.com>,
Rahul Bhansali <rbhansali@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>
Subject: Re: [PATCH v2] event/cnxk: fix LMTST write for single event mode
Date: Wed, 31 May 2023 18:54:39 +0530 [thread overview]
Message-ID: <CALBAE1MZ1vP95PVnRPtx_dhyASobrCf+GPVhfrxp5Oh7ZPa3ag@mail.gmail.com> (raw)
In-Reply-To: <PH0PR18MB40860CA79E974D52886238D4DE489@PH0PR18MB4086.namprd18.prod.outlook.com>
On Wed, May 31, 2023 at 4:25 PM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Srujana Challa <schalla@marvell.com>
> > Sent: Wednesday, May 31, 2023 4:03 PM
> > To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Shijith
> > Thotton <sthotton@marvell.com>; Rahul Bhansali <rbhansali@marvell.com>;
> > Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> > Cc: dev@dpdk.org; Srujana Challa <schalla@marvell.com>; Nithin Kumar
> > Dabilpuram <ndabilpuram@marvell.com>
> > Subject: [PATCH v2] event/cnxk: fix LMTST write for single event mode
> >
> > LMTST area can be overwritten before read by HW between to consecutive
> > steorl operations. Hence, add wmb() after steorl op to make sure
> > the LMTST operation is complete.
> >
> > Fixes: 313e884a22fd ("event/cnxk: support Tx adapter fast path")
> > Cc: pbhagavatula@marvell.com
> >
> > Signed-off-by: Srujana Challa <schalla@marvell.com>
>
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
>
> > ---
> > drivers/event/cnxk/cn10k_tx_worker.h | 8 +++-----
> > 1 file changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/event/cnxk/cn10k_tx_worker.h
> > b/drivers/event/cnxk/cn10k_tx_worker.h
> > index c18786a14c..81fe31c4b9 100644
> > --- a/drivers/event/cnxk/cn10k_tx_worker.h
> > +++ b/drivers/event/cnxk/cn10k_tx_worker.h
> > @@ -43,7 +43,6 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct
> > rte_mbuf *m, uint64_t *cmd,
> > const uint64_t *txq_data, const uint32_t flags)
> > {
> > uint8_t lnum = 0, loff = 0, shft = 0;
> > - uint16_t ref_cnt = m->refcnt;
> > struct cn10k_eth_txq *txq;
> > uintptr_t laddr;
> > uint16_t segdw;
> > @@ -98,10 +97,9 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct
> > rte_mbuf *m, uint64_t *cmd,
> >
> > roc_lmt_submit_steorl(lmt_id, pa);
> >
> > - if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F) {
> > - if (ref_cnt > 1)
> > - rte_io_wmb();
> > - }
> > + /* Memory barrier to make sure lmtst store completes */
> > + rte_io_wmb();
> > +
> > return 1;
> > }
> >
> > --
> > 2.25.1
>
prev parent reply other threads:[~2023-05-31 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 11:53 [PATCH] event/cnxk: add wmb after steorl for " Srujana Challa
2023-05-31 10:32 ` [PATCH v2] event/cnxk: fix LMTST write for single " Srujana Challa
2023-05-31 10:55 ` Pavan Nikhilesh Bhagavatula
2023-05-31 13:24 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1MZ1vP95PVnRPtx_dhyASobrCf+GPVhfrxp5Oh7ZPa3ag@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=rbhansali@marvell.com \
--cc=schalla@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).