From: Jerin Jacob <jerinjacobk@gmail.com>
To: psatheesh@marvell.com
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
Jerin Jacob <jerinj@marvell.com>,
dev@dpdk.org, stable@dpdk.org, Harman Kalra <hkalra@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] common/cnxk: fix Coverity issues
Date: Fri, 1 Mar 2024 00:01:39 +0530 [thread overview]
Message-ID: <CALBAE1Md=tJRQsYfvqUWRkxA+cin+wcJq==JR2y=7Q6NZ8Xodg@mail.gmail.com> (raw)
In-Reply-To: <20240228064643.1923169-1-psatheesh@marvell.com>
On Wed, Feb 28, 2024 at 12:25 PM <psatheesh@marvell.com> wrote:
>
> From: Satheesh Paul <psatheesh@marvell.com>
Please change the subject "common/cnxk: fix Coverity issues" and align
on what is fixed and send as separate patches.
> Fix Out-of-bounds access and remove dead code
> reported by Coverity.
>
> Coverity issue: 384431, 384439, 380992
> Fixes: 585bb3e538f9 ("common/cnxk: add VF support to base device class")
> Fixes: da1ec39060b2 ("common/cnxk: delay inline device RQ enable to dev start")
> Cc: stable@dpdk.org
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Reviewed-by: Harman Kalra <hkalra@marvell.com>
> ---
> drivers/common/cnxk/roc_dev.c | 2 ++
> drivers/common/cnxk/roc_nix_inl.c | 3 +--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c
> index 084343c3b4..14aff233d5 100644
> --- a/drivers/common/cnxk/roc_dev.c
> +++ b/drivers/common/cnxk/roc_dev.c
> @@ -502,6 +502,8 @@ pf_vf_mbox_send_up_msg(struct dev *dev, void *rec_msg)
> size_t size;
>
> size = PLT_ALIGN(mbox_id2size(msg->hdr.id), MBOX_MSG_ALIGN);
> + if (size < sizeof(struct mbox_msghdr))
> + return;
> /* Send UP message to all VF's */
> for (vf = 0; vf < vf_mbox->ndevs; vf++) {
> /* VF active */
> diff --git a/drivers/common/cnxk/roc_nix_inl.c b/drivers/common/cnxk/roc_nix_inl.c
> index a205c658e9..7dbeae5017 100644
> --- a/drivers/common/cnxk/roc_nix_inl.c
> +++ b/drivers/common/cnxk/roc_nix_inl.c
> @@ -677,8 +677,7 @@ roc_nix_reassembly_configure(uint32_t max_wait_time, uint16_t max_frags)
> return -EFAULT;
>
> PLT_SET_USED(max_frags);
> - if (idev == NULL)
> - return -ENOTSUP;
> +
> roc_cpt = idev->cpt;
> if (!roc_cpt) {
> plt_err("Cannot support inline inbound, cryptodev not probed");
> --
> 2.39.2
>
next prev parent reply other threads:[~2024-02-29 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 6:46 psatheesh
2024-02-29 18:31 ` Jerin Jacob [this message]
2024-03-01 3:35 ` [dpdk-dev] [PATCH v2 1/2] common/cnxk: remove dead code psatheesh
2024-03-01 3:35 ` [dpdk-dev] [PATCH v2 2/2] common/cnxk: fix possible out-of-bounds access psatheesh
2024-03-03 15:16 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1Md=tJRQsYfvqUWRkxA+cin+wcJq==JR2y=7Q6NZ8Xodg@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=psatheesh@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).