From: Jerin Jacob <jerinjacobk@gmail.com>
To: Vamsi Attunuru <vattunuru@marvell.com>, YuX <yux.jiang@intel.com>
Cc: dpdk-dev <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Srikanth Yalavarthi <syalavarthi@marvell.com>
Subject: Re: [PATCH 1/1] common/cnxk: fix static assertion failure
Date: Wed, 2 Mar 2022 18:16:33 +0530 [thread overview]
Message-ID: <CALBAE1MsOW1ddE=QLhnBCM5Ni2fut6Ucb-5+yzXRfwbD3m8j5w@mail.gmail.com> (raw)
In-Reply-To: <20220302120701.2749772-1-vattunuru@marvell.com>
On Wed, Mar 2, 2022 at 5:37 PM Vamsi Attunuru <vattunuru@marvell.com> wrote:
>
> use dynamically allocated memory for storing soft expiry
Use
> ring base addresses which fixes the static assertion failure,
> size of this dynamic allocation depends on RTE_MAX_ETHPORTS
as the size of
> which varies based on the build config.
>
Fill Bugzilla ID:
> Fixes: d26185716d3f ("net/cnxk: support outbound soft expiry
> notification")
Please move word "notification" to same line.
Add Cc: stable@dpdk.org
+ @yux.jiang@intel.com
Add Reported-by:
>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> ---
> +
> +/* Add / Sub pointer with scalar and cast to uint64_t */
> +#define PLT_PTR_ADD_U64_CAST(__ptr, __x) PLT_U64_CAST(PLT_PTR_ADD(__ptr, __x))
> +#define PLT_PTR_SUB_U64_CAST(__ptr, __x) PLT_U64_CAST(PLT_PTR_SUB(__ptr, __x))
Since it is not used in this patch, This line can be removed
> +
> /** Divide ceil */
> #define PLT_DIV_CEIL(x, y) \
> ({ \
> @@ -158,6 +170,10 @@
> #define plt_write64(val, addr) \
> rte_write64_relaxed((val), (volatile void *)(addr))
>
> +#define plt_read32(addr) rte_read32_relaxed((volatile void *)(addr))
> +#define plt_write32(val, addr) \
> + rte_write32_relaxed((val), (volatile void *)(addr))
Since it is not used in this patch, This line can be removed
next prev parent reply other threads:[~2022-03-02 12:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 12:07 Vamsi Attunuru
2022-03-02 12:46 ` Jerin Jacob [this message]
2022-03-02 13:46 ` [PATCH v2 " Vamsi Attunuru
2022-03-03 5:59 ` Jerin Jacob
2022-03-03 11:54 ` Ling, WeiX
2022-03-03 17:21 ` Ferruh Yigit
2022-03-04 10:20 ` [EXT] " Vamsi Krishna Attunuru
2022-03-04 11:15 ` Ferruh Yigit
2022-03-04 11:45 ` Vamsi Krishna Attunuru
2022-03-04 13:14 ` Ferruh Yigit
2022-03-04 13:59 ` Vamsi Krishna Attunuru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1MsOW1ddE=QLhnBCM5Ni2fut6Ucb-5+yzXRfwbD3m8j5w@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=syalavarthi@marvell.com \
--cc=vattunuru@marvell.com \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).