From: Jerin Jacob <jerinjacobk@gmail.com>
To: Satheesh Paul <psatheesh@marvell.com>
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>, dpdk-dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] common/cnxk: fix missing null check in IPv6 flow parsing
Date: Thu, 17 Feb 2022 10:04:41 +0530 [thread overview]
Message-ID: <CALBAE1N=1rfkcoR-roXgyckbL0HvLxGJrAnZUXhUuWXo_n94Fg@mail.gmail.com> (raw)
In-Reply-To: <20220125041248.905732-1-psatheesh@marvell.com>
On Tue, Jan 25, 2022 at 9:43 AM <psatheesh@marvell.com> wrote:
>
> From: Satheesh Paul <psatheesh@marvell.com>
>
> Added null check in IPv6 flow pattern parsing.
>
> Fixes: a55dc02af5 ("common/cnxk: support extensions attributes in IPv6 item")
The changeset is not correct.
> Cc: stable@dpdk.org
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Updated the git commit as follows and Applied to
dpdk-next-net-mrvl/for-next-net. Thanks
common/cnxk: fix null access in IPv6 flow parsing
Added null check in IPv6 flow pattern parsing.
Fixes: 474e275b1bc6 ("common/cnxk: support extensions attributes
in IPv6 item")
Cc: stable@dpdk.org
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
> ---
> drivers/common/cnxk/roc_npc_parse.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_npc_parse.c b/drivers/common/cnxk/roc_npc_parse.c
> index 1f21693369..302ab66efc 100644
> --- a/drivers/common/cnxk/roc_npc_parse.c
> +++ b/drivers/common/cnxk/roc_npc_parse.c
> @@ -562,9 +562,11 @@ npc_parse_lc(struct npc_parse_state *pst)
> ipv6_spec = pst->pattern->spec;
> lid = NPC_LID_LC;
> lt = NPC_LT_LC_IP6;
> - rc = npc_handle_ipv6ext_attr(ipv6_spec, pst, &flags);
> - if (rc)
> - return rc;
> + if (ipv6_spec) {
> + rc = npc_handle_ipv6ext_attr(ipv6_spec, pst, &flags);
> + if (rc)
> + return rc;
> + }
> info.len = sizeof(ipv6_spec->hdr);
> break;
> case ROC_NPC_ITEM_TYPE_ARP_ETH_IPV4:
> --
> 2.25.4
>
prev parent reply other threads:[~2022-02-17 4:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 4:12 psatheesh
2022-02-17 4:34 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1N=1rfkcoR-roXgyckbL0HvLxGJrAnZUXhUuWXo_n94Fg@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=psatheesh@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).