From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: arybchenko@solarflare.com, Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: add set supported types op
Date: Fri, 11 Oct 2019 13:32:19 +0530 [thread overview]
Message-ID: <CALBAE1NORAKa3c-hxo8Zv_9JNP9f92PMWURQsEgnSH1Xhm0qPw@mail.gmail.com> (raw)
In-Reply-To: <20191008090024.1250-1-pbhagavatula@marvell.com>
On Tue, Oct 8, 2019 at 2:30 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Add support to set supported ptypes for octeontx2.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> This patch depends on the following series
> http://patches.dpdk.org/project/dpdk/list/?series=6715
>
> drivers/net/octeontx2/otx2_ethdev.c | 1 +
> drivers/net/octeontx2/otx2_ethdev.h | 2 ++
> drivers/net/octeontx2/otx2_ethdev_devargs.c | 21 ---------------------
> drivers/net/octeontx2/otx2_lookup.c | 15 +++++++++++++++
Remove following from doc/guides/nics/octeontx2.rst as well.
- ``HW offload ptype parsing disable`` (default ``0``)
Packet type parsing is HW offloaded by default and this feature may
be toggled
using ``ptype_disable`` ``devargs`` parameter.
> 4 files changed, 18 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c
> index b84128fef..5ee0e382d 100644
> --- a/drivers/net/octeontx2/otx2_ethdev.c
> +++ b/drivers/net/octeontx2/otx2_ethdev.c
> @@ -1619,6 +1619,7 @@ static const struct eth_dev_ops otx2_eth_dev_ops = {
> .dev_set_link_up = otx2_nix_dev_set_link_up,
> .dev_set_link_down = otx2_nix_dev_set_link_down,
> .dev_supported_ptypes_get = otx2_nix_supported_ptypes_get,
> + .dev_supported_ptypes_set = otx2_nix_supported_ptypes_set,
> .dev_reset = otx2_nix_dev_reset,
> .stats_get = otx2_nix_dev_stats_get,
> .stats_reset = otx2_nix_dev_stats_reset,
> +int
> +otx2_nix_supported_ptypes_set(struct rte_eth_dev *eth_dev, uint32_t ptype_mask)
> +{
> + struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);
> +
> + if (!ptype_mask)
> + dev->rx_offload_flags &= ~NIX_RX_OFFLOAD_PTYPE_F;
> + else
> + dev->rx_offload_flags |= NIX_RX_OFFLOAD_PTYPE_F;
Prefer to have positive logic.
if (ptype_mask)
dev->rx_offload_flags |= NIX_RX_OFFLOAD_PTYPE_F;
else
dev->rx_offload_flags &= ~NIX_RX_OFFLOAD_PTYPE_F;
> +
> + otx2_eth_set_rx_function(eth_dev);
> +
> + return 0;
> +}
> +
> /*
> * +------------------ +------------------ +
> * | | IL4 | IL3| IL2 | TU | L4 | L3 | L2 |
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-10-11 8:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 9:00 pbhagavatula
2019-10-11 8:02 ` Jerin Jacob [this message]
2019-10-17 12:20 ` [dpdk-dev] [PATCH v2] " pbhagavatula
2019-10-17 16:22 ` Jerin Jacob
2019-10-17 16:51 ` [dpdk-dev] [PATCH v3] " pbhagavatula
2019-11-07 2:52 ` [dpdk-dev] [PATCH v4] " pbhagavatula
2019-11-15 10:17 ` Jerin Jacob
2019-11-15 13:44 ` Ferruh Yigit
2019-11-15 14:02 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1NORAKa3c-hxo8Zv_9JNP9f92PMWURQsEgnSH1Xhm0qPw@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).