From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Shijith Thotton <sthotton@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [PATCH] event/cnxk: fix qos devargs parsing
Date: Mon, 24 Jan 2022 14:34:42 +0530 [thread overview]
Message-ID: <CALBAE1NXMwkgVmb8c0taUpoU0QF7F8ekjrYCm18wOmRndMPCeg@mail.gmail.com> (raw)
In-Reply-To: <20211213204140.5255-1-pbhagavatula@marvell.com>
On Tue, Dec 14, 2021 at 2:11 AM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Fix qos devargs parsing using incorrect datatype for the
> structure elements.
>
> Fixes: 38c2e3240ba8 ("event/cnxk: add option to control SSO HWGRP QoS")
Cc: stable@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
> ---
> drivers/event/cnxk/cnxk_eventdev.c | 2 +-
> drivers/event/cnxk/cnxk_eventdev.h | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c
> index f7a5026250..6ad4e23e2b 100644
> --- a/drivers/event/cnxk/cnxk_eventdev.c
> +++ b/drivers/event/cnxk/cnxk_eventdev.c
> @@ -482,7 +482,7 @@ static void
> parse_queue_param(char *value, void *opaque)
> {
> struct cnxk_sso_qos queue_qos = {0};
> - uint8_t *val = (uint8_t *)&queue_qos;
> + uint16_t *val = (uint16_t *)&queue_qos;
> struct cnxk_sso_evdev *dev = opaque;
> char *tok = strtok(value, "-");
> struct cnxk_sso_qos *old_ptr;
> diff --git a/drivers/event/cnxk/cnxk_eventdev.h b/drivers/event/cnxk/cnxk_eventdev.h
> index 305c6a3b9e..4652b58a84 100644
> --- a/drivers/event/cnxk/cnxk_eventdev.h
> +++ b/drivers/event/cnxk/cnxk_eventdev.h
> @@ -74,9 +74,9 @@ typedef void (*cnxk_sso_hws_flush_t)(void *ws, uint8_t queue_id, uintptr_t base,
>
> struct cnxk_sso_qos {
> uint16_t queue;
> - uint8_t xaq_prcnt;
> - uint8_t taq_prcnt;
> - uint8_t iaq_prcnt;
> + uint16_t xaq_prcnt;
> + uint16_t taq_prcnt;
> + uint16_t iaq_prcnt;
> };
>
> struct cnxk_sso_evdev {
> --
> 2.17.1
>
prev parent reply other threads:[~2022-01-24 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 20:41 pbhagavatula
2022-01-24 9:04 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1NXMwkgVmb8c0taUpoU0QF7F8ekjrYCm18wOmRndMPCeg@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).