From: Jerin Jacob <jerinjacobk@gmail.com>
To: Markus Theil <markus.theil@tu-ilmenau.de>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [PATCH] doc: add deprecation notice for inconsistent socket_id types
Date: Fri, 14 Oct 2022 16:13:02 +0530 [thread overview]
Message-ID: <CALBAE1NYtHPB2g_V9ixDuo0qHNZgoUqUfVtwhTgqomKimfRZuQ@mail.gmail.com> (raw)
In-Reply-To: <20221014080944.10992-1-markus.theil@tu-ilmenau.de>
On Fri, Oct 14, 2022 at 1:39 PM Markus Theil <markus.theil@tu-ilmenau.de> wrote:
>
> DPDK uses many different types for socket_id's in its whole code
> base. This leads to many warnings and casts in DPDK-based applications
> compiled with -Wconversion.
>
> Announce a treewide consolidation to the return type of rte_socket_id
> in DPDK 23.11.
> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 05cacb3ea8..7f4c468542 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -96,3 +96,10 @@ Deprecation Notices
> to have another parameter ``qp_id`` to return the queue pair ID
> which got error interrupt to the application,
> so that application can reset that particular queue pair.
> +
> +* eal/treewide: currently socket_id's use many different data types
> + throughout the codebase. This complicates compiling DPDK-based
> + applications with enabled -Wconversion. Fix this, by changing
> + all occurences to the return type of rte_socket_id().
> + DPDK 23.11 should receive a batch cleanup to a single, consistent
> + data type.
> --
> 2.38.0
>
next prev parent reply other threads:[~2022-10-14 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 8:09 Markus Theil
2022-10-14 10:43 ` Jerin Jacob [this message]
2023-07-16 17:34 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1NYtHPB2g_V9ixDuo0qHNZgoUqUfVtwhTgqomKimfRZuQ@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=markus.theil@tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).