From: Jerin Jacob <jerinjacobk@gmail.com>
To: Nithin Dabilpuram <ndabilpuram@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [PATCH 20/20] net/cnxk: add option to override outbound inline sa iv
Date: Thu, 17 Feb 2022 19:24:48 +0530 [thread overview]
Message-ID: <CALBAE1NcyGiaUzz8SPUv2DoeBi5m6yZ0UN9SyduATeXv9Dk0aw@mail.gmail.com> (raw)
In-Reply-To: <20220207072932.22409-20-ndabilpuram@marvell.com>
On Mon, Feb 7, 2022 at 1:02 PM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
>
> Add option to override outbound inline sa iv for debug
sa -> SA
IV -> IV
Please check the subject too
> purposes via environment variable. User can set env variable as:
> export CN10K_ETH_SEC_IV_OVR="0x0, 0x0,..."
Please add a table for environment variables and usage in
doc/guides/platform/cnxk.rst
for the following ones as a separate patch and extended the new one there.
rivers/common/cnxk/roc_bphy_irq.c: env = getenv("BPHY_INTR_MLOCK_DISABLE");
drivers/common/cnxk/roc_mbox.c: var = getenv("ROC_CN10K_MBOX_TIMEOUT");
drivers/common/cnxk/roc_mbox.c: var_to = getenv("ROC_MBOX_TIMEOUT");
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> ---
> drivers/net/cnxk/cn10k_ethdev_sec.c | 62 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
> diff --git a/drivers/net/cnxk/cn10k_ethdev_sec.c b/drivers/net/cnxk/cn10k_ethdev_sec.c
> index a2a53c1..a514345 100644
> --- a/drivers/net/cnxk/cn10k_ethdev_sec.c
> +++ b/drivers/net/cnxk/cn10k_ethdev_sec.c
> @@ -252,6 +252,63 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args)
> cnxk_pktmbuf_free_no_cache(mbuf);
> }
>
> +static void
> +outb_dbg_iv_update(struct roc_ot_ipsec_outb_sa *outb_sa, const char *__iv_str)
> +{
> + uint8_t *iv_dbg = outb_sa->iv.iv_dbg;
> + char *iv_str = strdup(__iv_str);
> + char *iv_b = NULL, len = 16;
> + char *save;
> + int i;
> +
> + if (!iv_str)
> + return;
> +
> + if (outb_sa->w2.s.enc_type == ROC_IE_OT_SA_ENC_AES_GCM ||
> + outb_sa->w2.s.enc_type == ROC_IE_OT_SA_ENC_AES_CTR ||
> + outb_sa->w2.s.enc_type == ROC_IE_OT_SA_ENC_AES_CCM ||
> + outb_sa->w2.s.auth_type == ROC_IE_OT_SA_AUTH_AES_GMAC) {
> + memset(outb_sa->iv.s.iv_dbg1, 0, sizeof(outb_sa->iv.s.iv_dbg1));
> + memset(outb_sa->iv.s.iv_dbg2, 0, sizeof(outb_sa->iv.s.iv_dbg2));
> +
> + iv_dbg = outb_sa->iv.s.iv_dbg1;
> + for (i = 0; i < 4; i++) {
> + iv_b = strtok_r(i ? NULL : iv_str, ",", &save);
> + if (!iv_b)
> + break;
> + iv_dbg[i] = strtoul(iv_b, NULL, 0);
> + }
> + *(uint32_t *)iv_dbg = rte_be_to_cpu_32(*(uint32_t *)iv_dbg);
> +
> + iv_dbg = outb_sa->iv.s.iv_dbg2;
> + for (i = 0; i < 4; i++) {
> + iv_b = strtok_r(NULL, ",", &save);
> + if (!iv_b)
> + break;
> + iv_dbg[i] = strtoul(iv_b, NULL, 0);
> + }
> + *(uint32_t *)iv_dbg = rte_be_to_cpu_32(*(uint32_t *)iv_dbg);
> +
> + } else {
> + iv_dbg = outb_sa->iv.iv_dbg;
> + memset(iv_dbg, 0, sizeof(outb_sa->iv.iv_dbg));
> +
> + for (i = 0; i < len; i++) {
> + iv_b = strtok_r(i ? NULL : iv_str, ",", &save);
> + if (!iv_b)
> + break;
> + iv_dbg[i] = strtoul(iv_b, NULL, 0);
> + }
> + *(uint64_t *)iv_dbg = rte_be_to_cpu_64(*(uint64_t *)iv_dbg);
> + *(uint64_t *)&iv_dbg[8] =
> + rte_be_to_cpu_64(*(uint64_t *)&iv_dbg[8]);
> + }
> +
> + /* Update source of IV */
> + outb_sa->w2.s.iv_src = ROC_IE_OT_SA_IV_SRC_FROM_SA;
> + free(iv_str);
> +}
> +
> static int
> cn10k_eth_sec_session_create(void *device,
> struct rte_security_session_conf *conf,
> @@ -390,6 +447,7 @@ cn10k_eth_sec_session_create(void *device,
> struct cn10k_outb_priv_data *outb_priv;
> struct cnxk_ipsec_outb_rlens *rlens;
> uint64_t sa_base = dev->outb.sa_base;
> + const char *iv_str;
> uint32_t sa_idx;
>
> PLT_STATIC_ASSERT(sizeof(struct cn10k_outb_priv_data) <
> @@ -416,6 +474,10 @@ cn10k_eth_sec_session_create(void *device,
> goto mempool_put;
> }
>
> + iv_str = getenv("CN10K_ETH_SEC_IV_OVR");
> + if (iv_str)
> + outb_dbg_iv_update(outb_sa_dptr, iv_str);
> +
> /* Save userdata */
> outb_priv->userdata = conf->userdata;
> outb_priv->sa_idx = sa_idx;
> --
> 2.8.4
>
next prev parent reply other threads:[~2022-02-17 13:55 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 7:29 [PATCH 01/20] common/cnxk: increase resource count for bitmap alloc Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 02/20] common/cnxk: realloc inline device XAQ AURA Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 03/20] common/cnxk: adjust shaper rates to lower boundaries Nithin Dabilpuram
2022-02-17 13:20 ` Jerin Jacob
2022-02-22 18:19 ` Nithin Kumar Dabilpuram
2022-02-22 18:21 ` Jerin Jacob
2022-02-07 7:29 ` [PATCH 04/20] common/cnxk: support inline device API without ROC NIX Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 05/20] common/cnxk: use common SA init API for default options Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 06/20] common/cnxk: enable l3hdr write back in SA Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 07/20] common/cnxk: support to enable aura tail drop for RQ Nithin Dabilpuram
2022-02-17 13:24 ` Jerin Jacob
2022-02-07 7:29 ` [PATCH 08/20] common/cnxk: use SSO time counter threshold for IRQ Nithin Dabilpuram
2022-02-17 13:25 ` Jerin Jacob
2022-02-07 7:29 ` [PATCH 09/20] common/cnxk: allow force use of SSO pffunc for outb inline Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 10/20] net/cnxk: added Rx metadata negotiate operation Nithin Dabilpuram
2022-02-17 13:33 ` Jerin Jacob
2022-02-22 18:31 ` Nithin Kumar Dabilpuram
2022-02-07 7:29 ` [PATCH 11/20] common/cnxk: removed tracking of mark actions Nithin Dabilpuram
2022-02-17 13:36 ` Jerin Jacob
2022-02-07 7:29 ` [PATCH 12/20] net/cnxk: fix inline device RQ tag mask Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 13/20] net/cnxk: register callback early to handle initial packets Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 14/20] net/cnxk: realloc inline dev XAQ for security Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 15/20] net/cnxk: use raw mbuf free on inline sec err Nithin Dabilpuram
2022-02-17 13:45 ` Jerin Jacob
2022-02-07 7:29 ` [PATCH 16/20] net/cnxk: use NPA batch burst free for meta buffers Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 17/20] net/cnxk: enable packet pool tail drop Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 18/20] net/cnxk: enable flow control by default on device configure Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 19/20] net/cnxk: add dev args for min-max spi Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 20/20] net/cnxk: add option to override outbound inline sa iv Nithin Dabilpuram
2022-02-17 13:54 ` Jerin Jacob [this message]
2022-02-17 13:11 ` [PATCH 01/20] common/cnxk: increase resource count for bitmap alloc Jerin Jacob
2022-02-17 13:13 ` Jerin Jacob
2022-02-22 19:34 ` [PATCH v2 01/21] common/cnxk: increase SMQ resource count Nithin Dabilpuram
2022-02-22 19:34 ` [PATCH v2 02/21] common/cnxk: realloc inline device XAQ AURA Nithin Dabilpuram
2022-02-22 19:34 ` [PATCH v2 03/21] common/cnxk: adjust shaper rates to lower boundaries Nithin Dabilpuram
2022-02-22 19:34 ` [PATCH v2 04/21] common/cnxk: support inline device API without ROC NIX Nithin Dabilpuram
2022-02-22 19:34 ` [PATCH v2 05/21] common/cnxk: use common SA init API for default options Nithin Dabilpuram
2022-02-22 19:34 ` [PATCH v2 06/21] common/cnxk: enable l3hdr write back in SA Nithin Dabilpuram
2022-02-22 19:34 ` [PATCH v2 07/21] common/cnxk: support to enable AURA tail drop for RQ Nithin Dabilpuram
2022-02-22 19:34 ` [PATCH v2 08/21] common/cnxk: use SSO time counter threshold for IRQ Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 09/21] common/cnxk: allow force use of SSO pffunc for outb inline Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 10/21] net/cnxk: added Rx metadata negotiate operation Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 11/21] common/cnxk: remove tracking of mark actions Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 12/21] net/cnxk: fix inline device RQ tag mask Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 13/21] net/cnxk: register callback early to handle initial packets Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 14/21] net/cnxk: realloc inline dev XAQ for security Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 15/21] net/cnxk: fix inline IPsec security error handling Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 16/21] net/cnxk: use NPA batch burst free for meta buffers Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 17/21] net/cnxk: enable packet pool tail drop Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 18/21] net/cnxk: enable flow control by default on device configure Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 19/21] net/cnxk: add dev args for min-max spi Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 20/21] net/cnxk: add option to override outbound inline SA IV Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 21/21] doc: add table for environment variables used by cnxk Nithin Dabilpuram
2022-02-26 9:22 ` Thomas Monjalon
2022-02-26 9:37 ` Jerin Jacob
2022-02-26 13:31 ` Thomas Monjalon
2022-02-23 16:45 ` [PATCH v2 01/21] common/cnxk: increase SMQ resource count Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1NcyGiaUzz8SPUv2DoeBi5m6yZ0UN9SyduATeXv9Dk0aw@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).