From: Jerin Jacob <jerinjacobk@gmail.com>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: jerinj@marvell.com, hofors@lysator.liu.se, dev@dpdk.org,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
Timothy McDaniel <timothy.mcdaniel@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
Harry van Haaren <harry.van.haaren@intel.com>,
Liang Ma <liangma@liangbit.com>,
Peter Mccarthy <peter.mccarthy@intel.com>
Subject: Re: [RFC] eventdev: remove single-event enqueue operation
Date: Fri, 30 Jun 2023 10:07:25 +0530 [thread overview]
Message-ID: <CALBAE1Nek10TUkPwtDcfsF_aA8Q5=-rQvqG1xHQyxagavHMoRA@mail.gmail.com> (raw)
In-Reply-To: <20230609174205.150027-1-mattias.ronnblom@ericsson.com>
On Fri, Jun 9, 2023 at 11:18 PM Mattias Rönnblom
<mattias.ronnblom@ericsson.com> wrote:
>
> Eliminate non-burst enqueue operation from Eventdev.
>
> The effect of this change is to reduce Eventdev code complexity
> somewhat and slightly improve performance.
>
> The single-event enqueue shortcut provided a very minor performance
> advantage in some situations (e.g., with a compile time-constant burst
> size of '1'), but would in other situations cause a noticeable
> performance penalty (e.g., rte_event_enqueue_forward_burst() with run
> time-variable burst sizes varying between '1' and larger burst sizes).
>
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
>
> -typedef uint16_t (*event_enqueue_t)(void *port, const struct rte_event *ev);
> -/**< @internal Enqueue event on port of a device */
> -
> typedef uint16_t (*event_enqueue_burst_t)(void *port,
> const struct rte_event ev[],
> uint16_t nb_events);
> @@ -45,8 +42,6 @@ typedef uint16_t (*event_crypto_adapter_enqueue_t)(void *port,
> struct rte_event_fp_ops {
> void **data;
> /**< points to array of internal port data pointers */
> - event_enqueue_t enqueue;
> - /**< PMD enqueue function. */
Can we remove "dequeue" as well?
In any event, Please send a deprecation notice as it is an ABI change,
and we need to get merge the deprecation notice patch for v23.07.
I can review the deprecation notice patch quickly as soon as you send
it to make forward progress.
> event_enqueue_burst_t enqueue_burst;
> /**< PMD enqueue burst function. */
> event_enqueue_burst_t enqueue_new_burst;
> @@ -65,7 +60,7 @@ struct rte_event_fp_ops {
> /**< PMD Tx adapter enqueue same destination function. */
> event_crypto_adapter_enqueue_t ca_enqueue;
> /**< PMD Crypto adapter enqueue function. */
> - uintptr_t reserved[6];
> + uintptr_t reserved[7];
> } __rte_cache_aligned;
>
next prev parent reply other threads:[~2023-06-30 4:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 17:42 Mattias Rönnblom
2023-06-30 4:37 ` Jerin Jacob [this message]
2023-07-04 12:01 ` Mattias Rönnblom
2023-07-04 11:53 ` [PATCH] " Mattias Rönnblom
2023-07-05 7:47 ` Jerin Jacob
2023-07-05 8:41 ` Mattias Rönnblom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1Nek10TUkPwtDcfsF_aA8Q5=-rQvqG1xHQyxagavHMoRA@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=hofors@lysator.liu.se \
--cc=jerinj@marvell.com \
--cc=liangma@liangbit.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=pbhagavatula@marvell.com \
--cc=peter.mccarthy@intel.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=timothy.mcdaniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).