From: Jerin Jacob <jerinjacobk@gmail.com>
To: Ankur Dwivedi <adwivedi@marvell.com>
Cc: dev@dpdk.org, gakhil@marvell.com, vattunuru@marvell.com,
jerinj@marvell.com
Subject: Re: [PATCH v1 1/2] common/cnxk: add sa to port mapping
Date: Thu, 24 Aug 2023 17:50:10 +0530 [thread overview]
Message-ID: <CALBAE1Ng4p8fJXBBBO_M++cJVKeZc_XRMge=w8mythmNucPJGg@mail.gmail.com> (raw)
In-Reply-To: <20230823055000.2692083-2-adwivedi@marvell.com>
On Wed, Aug 23, 2023 at 12:15 PM Ankur Dwivedi <adwivedi@marvell.com> wrote:
>
> Adds sa to port mapping in roc mcs. This helps to propagate the tx and
> rx pn threshold events to the correct ethernet device.
>
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> ---
> drivers/common/cnxk/roc_mcs.c | 22 +++++++++++++++++++---
> drivers/common/cnxk/roc_mcs.h | 8 ++++++--
> drivers/common/cnxk/roc_mcs_sec_cfg.c | 6 ++++++
> drivers/common/cnxk/version.map | 1 +
> 4 files changed, 32 insertions(+), 5 deletions(-)
Found following build issue. Please fix and resend
[for-next-net]dell[dpdk-next-net-mrvl] $ gcc -v
Using built-in specs.
COLLECT_GCC=/usr/bin/gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-pc-linux-gnu/13.2.1/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /build/gcc/src/gcc/configure
--enable-languages=ada,c,c++,d,fortran,go,lto,objc,obj-c++
--enable-bootstrap --prefix=/usr --libdir=/usr/lib
--libexecdir=/usr/lib --mandir=/usr/share/man
--infodir=/usr/share/info --with-bugur
l=https://bugs.archlinux.org/ --with-build-config=bootstrap-lto
--with-linker-hash-style=gnu --with-system-zlib --enable-__cxa_atexit
--enable-cet=auto --enable-checking=release --enable-clocale=gnu
--enable-default-pie --enable-default-ssp
--enable-gnu-indirect-function --enable-gnu-unique-object
--enable-libstdcxx-backtrace --enable-link-serialization=1
--enable-linker-build-id --enable-lto --enable-multilib
--enable-plugin --enable-shared --enable-threads=posix --disable-l
ibssp --disable-libstdcxx-pch --disable-werror
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 13.2.1 20230801 (GCC)
[1778/2638] Compiling C object
drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_cnxk_ethdev_mcs.c.o
FAILED: drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_cnxk_ethdev_mcs.c.o
ccache gcc -Idrivers/libtmp_rte_net_cnxk.a.p -Idrivers -I../drivers
-Idrivers/net/cnxk -I../drivers/net/cnxk -Ilib/ethdev -I../lib/ethdev
-I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include
-Ilib/eal/linux/include -I../lib/
eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include
-Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal
-Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics
-Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/n
et -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring
-I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci
-I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci
-Idrivers/bus/vdev -I../drivers/bus/vdev
-Ilib/cryptodev -I../lib/cryptodev -Ilib/rcu -I../lib/rcu
-Ilib/eventdev -I../lib/eventdev -Ilib/hash -I../lib/hash -Ilib/timer
-I../lib/timer -Ilib/security -I../lib/security -Idrivers/common/cnxk
-I../drivers/common/cnxk -Idrivers/mempoo
l/cnxk -I../drivers/mempool/cnxk -fdiagnostics-color=always
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -O2 -g
-include rte_config.h -Wcast-qual -Wdeprecated -Wformat
-Wformat-nonliteral -Wformat-security -Wmissing-declaratio
ns -Wmissing-prototypes -Wnested-externs -Wold-style-definition
-Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef
-Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned
-Wno-missing-field-initializers -Wno-zero-lengt
h-bounds -D_GNU_SOURCE -fPIC -march=native -DALLOW_EXPERIMENTAL_API
-DALLOW_INTERNAL_API -Wno-format-truncation -flax-vector-conversions
-Wno-strict-aliasing -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.cnxk -MD -MQ
drivers/libtmp_rte_net_cnxk.a.p/net
_cnxk_cnxk_ethdev_mcs.c.o -MF
drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_cnxk_ethdev_mcs.c.o.d -o
drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_cnxk_ethdev_mcs.c.o -c
../drivers/net/cnxk/cnxk_ethdev_mcs.c
../drivers/net/cnxk/cnxk_ethdev_mcs.c: In function ‘cnxk_mcs_dev_init’:
../drivers/net/cnxk/cnxk_ethdev_mcs.c:707:40: error: passing argument
3 of ‘roc_mcs_event_cb_register’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
707 | cnxk_mcs_event_cb,
dev->eth_dev, mcs_dev);
| ^~~~~~~~~~~~~~~~~
| |
| int (*)(void *, struct
roc_mcs_event_desc *, void *)
In file included from ../drivers/common/cnxk/roc_api.h:118,
from ../drivers/net/cnxk/cnxk_ethdev.h:24,
from ../drivers/net/cnxk/cnxk_ethdev_mcs.c:5:
../drivers/common/cnxk/roc_mcs.h:598:59: note: expected
‘roc_mcs_dev_cb_fn’ {aka ‘int (*)(void *, struct roc_mcs_event_desc *,
void *, unsigned char)’} but argument is of type ‘int (*)(void *,
struct roc_mcs_event_desc *, void *)’
598 | roc_mcs_dev_cb_fn
cb_fn, void *cb_arg, void *userdata);
| ~~~~~~~~~~~~~~~~~~^~~~~
../drivers/net/cnxk/cnxk_ethdev_mcs.c:714:40: error: passing argument
3 of ‘roc_mcs_event_cb_register’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
714 | cnxk_mcs_event_cb,
dev->eth_dev, mcs_dev);
| ^~~~~~~~~~~~~~~~~
| |
| int (*)(void *, struct
roc_mcs_event_desc *, void *)
../drivers/common/cnxk/roc_mcs.h:598:59: note: expected
‘roc_mcs_dev_cb_fn’ {aka ‘int (*)(void *, struct roc_mcs_event_desc *,
void *, unsigned char)’} but argument is of type ‘int (*)(void *,
struct roc_mcs_event_desc *, void *)’
598 | roc_mcs_dev_cb_fn
cb_fn, void *cb_arg, void *userdata);
| ~~~~~~~~~~~~~~~~~~^~~~~
../drivers/net/cnxk/cnxk_ethdev_mcs.c:721:40: error: passing argument
3 of ‘roc_mcs_event_cb_register’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
721 | cnxk_mcs_event_cb,
dev->eth_dev, mcs_dev);
| ^~~~~~~~~~~~~~~~~
| |
| int (*)(void *, struct
roc_mcs_event_desc *, void *)
../drivers/common/cnxk/roc_mcs.h:598:59: note: expected
‘roc_mcs_dev_cb_fn’ {aka ‘int (*)(void *, struct roc_mcs_event_desc *,
void *, unsigned char)’} but argument is of type ‘int (*)(void *,
struct roc_mcs_event_desc *, void *)’
598 | roc_mcs_dev_cb_fn
cb_fn, void *cb_arg, void *userdata);
| ~~~~~~~~~~~~~~~~~~^~~~~
next prev parent reply other threads:[~2023-08-24 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 5:49 [PATCH v1 0/2] support of MACsec PN threshold events on multiple ports Ankur Dwivedi
2023-08-23 5:49 ` [PATCH v1 1/2] common/cnxk: add sa to port mapping Ankur Dwivedi
2023-08-24 12:20 ` Jerin Jacob [this message]
2023-08-23 5:50 ` [PATCH v1 2/2] net/cnxk: update sa to port map Ankur Dwivedi
2023-08-25 10:36 ` [PATCH v2 0/1] support for MACsec PN threshold events on multiple ports Ankur Dwivedi
2023-08-25 10:36 ` [PATCH v2 1/1] net/cnxk: support " Ankur Dwivedi
2023-08-28 13:08 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1Ng4p8fJXBBBO_M++cJVKeZc_XRMge=w8mythmNucPJGg@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=adwivedi@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).