From: Jerin Jacob <jerinjacobk@gmail.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: Rakesh Kudurumalla <rkudurumalla@marvell.com>,
Ori Kam <orika@nvidia.com>,
Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
jerinj@marvell.com, ndabilpuram@marvell.com, dev@dpdk.org,
David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH v6 1/3] ethdev: skip congestion management configuration
Date: Sat, 11 Feb 2023 10:46:33 +0530 [thread overview]
Message-ID: <CALBAE1OKxxxXsBGXz_U1-VXGvWUKSfwuAjeRuF=g6zz7GXfJEQ@mail.gmail.com> (raw)
In-Reply-To: <f765e0b2-8bbd-335b-ab77-c38c4ad7634e@amd.com>
On Sat, Feb 11, 2023 at 6:05 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
> On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote:
> > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> > index b60987db4b..f4eb4232d4 100644
> > --- a/lib/ethdev/rte_flow.h
> > +++ b/lib/ethdev/rte_flow.h
> > @@ -2203,6 +2203,17 @@ enum rte_flow_action_type {
> > */
> > RTE_FLOW_ACTION_TYPE_DROP,
> >
> > + /**
> > + * Skip congestion management configuration
> > + *
> > + * Using rte_eth_cman_config_set() API the application
> > + * can configure ethdev Rx queue's congestion mechanism.
> > + * Introducing RTE_FLOW_ACTION_TYPE_SKIP_CMAN flow action to skip the
> > + * congestion configuration applied to the given ethdev Rx queue.
> > + *
> > + */
> > + RTE_FLOW_ACTION_TYPE_SKIP_CMAN,
> > +
>
> Inserting new enum item in to the middle of the enum upsets the ABI
> checks [1], can it go to the end?
Yes.
>
>
>
>
> [1]
> 1 function with some indirect sub-type change:
>
> [C] 'function size_t rte_flow_copy(rte_flow_desc*, size_t, const
> rte_flow_attr*, const rte_flow_item*, const rte_flow_action*)' at
> rte_flow.c:1092:1 has some indirect sub-type changes:
> parameter 1 of type 'rte_flow_desc*' has sub-type changes:
> in pointed to type 'struct rte_flow_desc' at rte_flow.h:4326:1:
> type size hasn't changed
> 1 data member changes (1 filtered):
> type of 'rte_flow_action* actions' changed:
> in pointed to type 'struct rte_flow_action' at
> rte_flow.h:3775:1:
> type size hasn't changed
> 1 data member change:
> type of 'rte_flow_action_type type' changed:
> type size hasn't changed
> 1 enumerator insertion:
>
> 'rte_flow_action_type::RTE_FLOW_ACTION_TYPE_SKIP_CMAN' value '8'
> 50 enumerator changes:
> 'rte_flow_action_type::RTE_FLOW_ACTION_TYPE_COUNT'
> from value '8' to '9' at rte_flow.h:2216:1
> ...
next prev parent reply other threads:[~2023-02-11 5:17 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 1:39 [PATCH 1/3] lib: dpdk spec to skip red for ingress policer Rakesh Kudurumalla
2022-12-22 1:39 ` [PATCH 2/3] app/testpmd: add skip red for testpmd Rakesh Kudurumalla
2022-12-22 1:39 ` [PATCH 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2022-12-22 3:01 ` [PATCH 1/3] lib: dpdk spec to skip red " Stephen Hemminger
2022-12-22 5:27 ` Jerin Jacob
2022-12-26 17:00 ` Ori Kam
2023-01-10 6:42 ` Rakesh Kudurumalla
2023-01-18 8:09 ` Rakesh Kudurumalla
2023-01-23 13:13 ` Jerin Jacob
2023-01-26 15:13 ` Ori Kam
2023-01-27 6:23 ` Jerin Jacob
2023-02-01 17:49 ` Ori Kam
2023-02-01 18:37 ` Jerin Jacob
2023-02-02 7:31 ` Ori Kam
2023-02-06 3:31 ` Jerin Jacob
2023-01-25 7:32 ` [PATCH v2 1/3] lib: skip congestion management configuration Rakesh Kudurumalla
2023-01-25 7:32 ` [PATCH v2 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-01-25 7:32 ` [PATCH v2 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-01-25 9:26 ` [PATCH v2 1/3] lib: skip congestion management configuration Jerin Jacob
2023-02-09 7:24 ` [PATCH v3 " Rakesh Kudurumalla
2023-02-09 7:24 ` [PATCH v3 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-09 7:24 ` [PATCH v3 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-09 7:31 ` [PATCH v3 1/3] lib: skip congestion management configuration Jerin Jacob
2023-02-09 8:35 ` [PATCH v4 1/3] ethdev: " Rakesh Kudurumalla
2023-02-09 8:35 ` [PATCH v4 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-09 8:35 ` [PATCH v4 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-09 17:14 ` Jerin Jacob
2023-02-09 14:51 ` [PATCH v4 1/3] ethdev: skip congestion management configuration Ori Kam
2023-02-10 8:14 ` [PATCH v5 " Rakesh Kudurumalla
2023-02-10 8:14 ` [PATCH v5 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-10 8:14 ` [PATCH v5 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-10 8:16 ` [PATCH v5 1/3] ethdev: skip congestion management configuration Jerin Jacob
2023-02-10 8:26 ` [PATCH v6 " Rakesh Kudurumalla
2023-02-10 8:26 ` [PATCH v6 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-10 23:08 ` Ferruh Yigit
2023-02-14 13:12 ` Ferruh Yigit
2023-02-10 8:26 ` [PATCH v6 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-10 23:18 ` Ferruh Yigit
2023-02-10 9:27 ` [PATCH v6 1/3] ethdev: skip congestion management configuration Jerin Jacob
2023-02-10 23:10 ` Ferruh Yigit
2023-02-13 12:34 ` Ori Kam
2023-02-13 13:54 ` Ferruh Yigit
2023-02-13 15:44 ` Jerin Jacob
2023-02-13 15:53 ` Ferruh Yigit
2023-02-11 0:35 ` Ferruh Yigit
2023-02-11 5:16 ` Jerin Jacob [this message]
2023-02-12 9:00 ` [PATCH v7 " Rakesh Kudurumalla
2023-02-12 9:00 ` [PATCH v7 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-12 9:00 ` [PATCH v7 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-14 13:04 ` [PATCH v8 1/4] ethdev: skip congestion management configuration Rakesh Kudurumalla
2023-02-14 13:04 ` [PATCH v8 2/4] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-14 13:21 ` Ferruh Yigit
2023-02-14 13:04 ` [PATCH v8 3/4] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-14 13:04 ` [PATCH v8 4/4] doc: update release notes for 23_03.rst Rakesh Kudurumalla
2023-02-14 13:19 ` Ferruh Yigit
2023-02-14 13:13 ` [PATCH v8 1/4] ethdev: skip congestion management configuration Ferruh Yigit
2023-02-15 6:25 ` [PATCH v9 1/3] " Rakesh Kudurumalla
2023-02-15 6:25 ` [PATCH v9 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-15 6:25 ` [PATCH v9 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-15 9:45 ` Ferruh Yigit
2023-02-15 10:00 ` Nithin Kumar Dabilpuram
2023-02-15 9:43 ` [PATCH v9 1/3] ethdev: skip congestion management configuration Ferruh Yigit
2023-02-15 17:42 ` [PATCH v10 " Rakesh Kudurumalla
2023-02-15 17:42 ` [PATCH v10 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-16 12:19 ` Ferruh Yigit
2023-02-15 17:42 ` [PATCH v10 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-16 14:51 ` [PATCH v11 1/3] ethdev: skip congestion management configuration Rakesh Kudurumalla
2023-02-16 14:51 ` [PATCH v11 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-16 14:51 ` [PATCH v11 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-16 16:18 ` [PATCH v11 1/3] ethdev: skip congestion management configuration Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1OKxxxXsBGXz_U1-VXGvWUKSfwuAjeRuF=g6zz7GXfJEQ@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=orika@nvidia.com \
--cc=rkudurumalla@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).