From: Jerin Jacob <jerinjacobk@gmail.com>
To: Tomasz Duszynski <tduszynski@marvell.com>
Cc: dpdk-dev <dev@dpdk.org>, Jakub Palider <jpalider@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>,
Jerin Jacob <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH 6/6] raw/cnxk_bphy: use named value for queue count
Date: Tue, 28 Sep 2021 14:48:14 +0530 [thread overview]
Message-ID: <CALBAE1Oe_b0SRPcsDL2Dz85BEULpiGV6hHQV-Ud47Ur9F2XxLQ@mail.gmail.com> (raw)
In-Reply-To: <20210726135815.81201-7-tduszynski@marvell.com>
On Mon, Jul 26, 2021 at 7:29 PM Tomasz Duszynski <tduszynski@marvell.com> wrote:
>
> From: Jakub Palider <jpalider@marvell.com>
>
> Queue counter is used in a few places so it was given some
> reasonable name.
>
> Signed-off-by: Jakub Palider <jpalider@marvell.com>
Series Acked-by: Jerin Jacob <jerinj@marvell.com>
Series applied to dpdk-next-net-mrvl/for-next-net. Thanks.
> ---
> drivers/raw/cnxk_bphy/cnxk_bphy.c | 2 ++
> drivers/raw/cnxk_bphy/cnxk_bphy_irq.h | 3 ++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c
> index affc5c3e83..030beff05e 100644
> --- a/drivers/raw/cnxk_bphy/cnxk_bphy.c
> +++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c
> @@ -51,6 +51,8 @@ bphy_rawdev_selftest(uint16_t dev_id)
> queues = rte_rawdev_queue_count(dev_id);
> if (queues == 0)
> return -ENODEV;
> + if (queues != BPHY_QUEUE_CNT)
> + return -EINVAL;
>
> ret = rte_rawdev_start(dev_id);
> if (ret)
> diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_irq.h b/drivers/raw/cnxk_bphy/cnxk_bphy_irq.h
> index b55147b93e..f141677e2a 100644
> --- a/drivers/raw/cnxk_bphy/cnxk_bphy_irq.h
> +++ b/drivers/raw/cnxk_bphy/cnxk_bphy_irq.h
> @@ -23,10 +23,11 @@ struct bphy_irq_queue {
> };
>
> struct bphy_device {
> +#define BPHY_QUEUE_CNT 1
> struct roc_bphy_irq_chip *irq_chip;
> struct bphy_mem mem;
> /* bphy irq interface supports single queue only */
> - struct bphy_irq_queue queues[1];
> + struct bphy_irq_queue queues[BPHY_QUEUE_CNT];
> };
>
> int cnxk_bphy_intr_init(uint16_t dev_id);
> --
> 2.25.1
>
prev parent reply other threads:[~2021-09-28 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 13:58 [dpdk-dev] [PATCH 0/6] common/cnxk: sync with local codebase Tomasz Duszynski
2021-07-26 13:58 ` [dpdk-dev] [PATCH 1/6] common/cnxk: return saner error codes Tomasz Duszynski
2021-07-26 13:58 ` [dpdk-dev] [PATCH 2/6] common/cnxk: remove duplicated constant Tomasz Duszynski
2021-07-26 13:58 ` [dpdk-dev] [PATCH 3/6] raw/cnxk_bphy: don't include irq header directly Tomasz Duszynski
2021-07-26 13:58 ` [dpdk-dev] [PATCH 4/6] common/cnxk: reduce function visibility Tomasz Duszynski
2021-07-26 13:58 ` [dpdk-dev] [PATCH 5/6] common/cnxk: align function naming Tomasz Duszynski
2021-07-26 13:58 ` [dpdk-dev] [PATCH 6/6] raw/cnxk_bphy: use named value for queue count Tomasz Duszynski
2021-09-28 9:18 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1Oe_b0SRPcsDL2Dz85BEULpiGV6hHQV-Ud47Ur9F2XxLQ@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jpalider@marvell.com \
--cc=tduszynski@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).