From: Jerin Jacob <jerinjacobk@gmail.com>
To: psatheesh@marvell.com
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
dev@dpdk.org, Jerin Jacob <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] common/cnxk: move ICMP ltype to end of enum
Date: Mon, 9 Jan 2023 20:57:58 +0530 [thread overview]
Message-ID: <CALBAE1OhWi5WuGiTAZnvL3yhTX=LQx+Qj0rD5EEfth26zCX-nA@mail.gmail.com> (raw)
In-Reply-To: <20221201040344.2977495-1-psatheesh@marvell.com>
On Thu, Dec 1, 2022 at 9:33 AM <psatheesh@marvell.com> wrote:
>
> From: Kiran Kumar K <kirankumark@marvell.com>
>
> While configuring the RSS key, mask has been created to match multiple
> ltypes for L4. Since ICMP is placed in between, it is also being
> considered for RSS. So, moving the ICMP to end of enum.
>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
> Reviewed-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
> ---
> drivers/common/cnxk/hw/npc.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/common/cnxk/hw/npc.h b/drivers/common/cnxk/hw/npc.h
> index b8218e25af..4164c6ac2e 100644
> --- a/drivers/common/cnxk/hw/npc.h
> +++ b/drivers/common/cnxk/hw/npc.h
> @@ -219,8 +219,7 @@ enum npc_kpu_lc_ltype {
> enum npc_kpu_ld_ltype {
> NPC_LT_LD_TCP = 1,
> NPC_LT_LD_UDP,
> - NPC_LT_LD_ICMP,
> - NPC_LT_LD_SCTP,
> + NPC_LT_LD_SCTP = 4,
> NPC_LT_LD_ICMP6,
> NPC_LT_LD_CUSTOM0,
> NPC_LT_LD_CUSTOM1,
> @@ -231,6 +230,7 @@ enum npc_kpu_ld_ltype {
> NPC_LT_LD_NSH,
> NPC_LT_LD_TU_MPLS_IN_NSH,
> NPC_LT_LD_TU_MPLS_IN_IP,
> + NPC_LT_LD_ICMP,
> };
>
> enum npc_kpu_le_ltype {
> @@ -276,14 +276,14 @@ enum npc_kpu_lg_ltype {
> enum npc_kpu_lh_ltype {
> NPC_LT_LH_TU_TCP = 1,
> NPC_LT_LH_TU_UDP,
> - NPC_LT_LH_TU_ICMP,
> - NPC_LT_LH_TU_SCTP,
> + NPC_LT_LH_TU_SCTP = 4,
> NPC_LT_LH_TU_ICMP6,
> + NPC_LT_LH_CUSTOM0,
> + NPC_LT_LH_CUSTOM1,
> NPC_LT_LH_TU_IGMP = 8,
> NPC_LT_LH_TU_ESP,
> NPC_LT_LH_TU_AH,
> - NPC_LT_LH_CUSTOM0 = 0xE,
> - NPC_LT_LH_CUSTOM1 = 0xF,
> + NPC_LT_LH_TU_ICMP = 0xF,
> };
>
> enum npc_kpu_lb_uflag {
> --
> 2.35.3
>
prev parent reply other threads:[~2023-01-09 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 4:03 psatheesh
2023-01-09 15:27 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1OhWi5WuGiTAZnvL3yhTX=LQx+Qj0rD5EEfth26zCX-nA@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=psatheesh@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).