DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Shijith Thotton <sthotton@marvell.com>
Cc: dpdk-dev <dev@dpdk.org>, "Jerin Jacob" <jerinj@marvell.com>,
	"Pavan Nikhilesh" <pbhagavatula@marvell.com>,
	"Van Haaren, Harry" <harry.van.haaren@intel.com>,
	"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: Re: [PATCH v2 4/6] test/event: test cases to test runtime queue attribute
Date: Mon, 9 May 2022 18:25:28 +0530	[thread overview]
Message-ID: <CALBAE1P-4HTTHwX7+ed7h=m9_XEGy2D7LWjMOE=F5tkfmztrrg@mail.gmail.com> (raw)
In-Reply-To: <d5a2bc601be7aa609de8d520544d8cb36cbca02b.1649136534.git.sthotton@marvell.com>

On Tue, Apr 5, 2022 at 11:12 AM Shijith Thotton <sthotton@marvell.com> wrote:
>
> Added test cases to test changing of queue QoS attributes priority,
> weight and affinity at runtime.
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> ---
>  app/test/test_eventdev.c | 149 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 149 insertions(+)
>
> diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c
> index 4f51042bda..1af93d3b77 100644
> --- a/app/test/test_eventdev.c
> +++ b/app/test/test_eventdev.c
> @@ -385,6 +385,149 @@ test_eventdev_queue_attr_priority(void)
>         return TEST_SUCCESS;
>  }
>
> +static int
> +test_eventdev_queue_attr_priority_runtime(void)
> +{
> +       struct rte_event_queue_conf qconf;
> +       struct rte_event_dev_info info;
> +       uint32_t queue_count;
> +       int i, ret;
> +
> +       ret = rte_event_dev_info_get(TEST_DEV_ID, &info);
> +       TEST_ASSERT_SUCCESS(ret, "Failed to get event dev info");
> +
> +       if (!(info.event_dev_cap & RTE_EVENT_DEV_CAP_RUNTIME_QUEUE_ATTR))
> +               return TEST_SKIPPED;
> +
> +               set_val = i % RTE_EVENT_DEV_PRIORITY_LOWEST;
> +               TEST_ASSERT_SUCCESS(
> +                       rte_event_queue_attr_set(TEST_DEV_ID, i,
> +                                                RTE_EVENT_QUEUE_ATTR_PRIORITY,
> +                                                set_val),
> +                       "Queue priority set failed");

If the return code is -ENOSUP, Please mark the test as TEST_SKIPPED

> +               TEST_ASSERT_SUCCESS(
> +                       rte_event_queue_attr_get(TEST_DEV_ID, i,
> +                                                RTE_EVENT_QUEUE_ATTR_PRIORITY,
> +                                                &get_val),
> +                       "Queue priority get failed");
> +               TEST_ASSERT_EQUAL(get_val, set_val,
> +                                 "Wrong priority value for queue%d", i);
> +       }
> +
> +       return TEST_SUCCESS;
> +}
> +
> +static int
> +test_eventdev_queue_attr_weight_runtime(void)
> +{
> +       struct rte_event_queue_conf qconf;
> +       struct rte_event_dev_info info;
> +       uint32_t queue_count;
> +       int i, ret;
> +
> +       ret = rte_event_dev_info_get(TEST_DEV_ID, &info);
> +       TEST_ASSERT_SUCCESS(ret, "Failed to get event dev info");
> +
> +       if (!(info.event_dev_cap & RTE_EVENT_DEV_CAP_RUNTIME_QUEUE_ATTR))
> +               return TEST_SKIPPED;
> +
> +       TEST_ASSERT_SUCCESS(rte_event_dev_attr_get(
> +                                   TEST_DEV_ID, RTE_EVENT_DEV_ATTR_QUEUE_COUNT,
> +                                   &queue_count),
> +                           "Queue count get failed");
> +
> +       for (i = 0; i < (int)queue_count; i++) {
> +               ret = rte_event_queue_default_conf_get(TEST_DEV_ID, i, &qconf);
> +               TEST_ASSERT_SUCCESS(ret, "Failed to get queue%d def conf", i);
> +               ret = rte_event_queue_setup(TEST_DEV_ID, i, &qconf);
> +               TEST_ASSERT_SUCCESS(ret, "Failed to setup queue%d", i);
> +       }
> +
> +       for (i = 0; i < (int)queue_count; i++) {
> +               uint32_t get_val;
> +               uint64_t set_val;
> +
> +               set_val = i % RTE_EVENT_QUEUE_WEIGHT_HIGHEST;
> +               TEST_ASSERT_SUCCESS(
> +                       rte_event_queue_attr_set(TEST_DEV_ID, i,
> +                                                RTE_EVENT_QUEUE_ATTR_WEIGHT,
> +                                                set_val),
> +                       "Queue weight set failed");

If the return code is -ENOSUP, Please mark the test as TEST_SKIPPED


> +               TEST_ASSERT_SUCCESS(rte_event_queue_attr_get(
> +                                           TEST_DEV_ID, i,
> +                                           RTE_EVENT_QUEUE_ATTR_WEIGHT, &get_val),
> +                                   "Queue weight get failed");
> +               TEST_ASSERT_EQUAL(get_val, set_val,
> +                                 "Wrong weight value for queue%d", i);
> +       }
> +
> +       return TEST_SUCCESS;
> +}
> +
> +static int
> +test_eventdev_queue_attr_affinity_runtime(void)
> +{

Please use rte_event_dequeue_burst() to get APIs to test the full
functionality to validate the
feature for both priority and affinity test cases.

  reply	other threads:[~2022-05-09 12:55 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29 13:10 [PATCH 0/6] Extend and set event queue attributes at runtime Shijith Thotton
2022-03-29 13:11 ` [PATCH 1/6] eventdev: support to set " Shijith Thotton
2022-03-30 10:58   ` Van Haaren, Harry
2022-04-04  9:35     ` Shijith Thotton
2022-04-04  9:45       ` Van Haaren, Harry
2022-03-30 12:14   ` Mattias Rönnblom
2022-04-04 11:45     ` Shijith Thotton
2022-03-29 13:11 ` [PATCH 2/6] eventdev: add weight and affinity to queue attributes Shijith Thotton
2022-03-30 12:12   ` Mattias Rönnblom
2022-04-04  9:33     ` Shijith Thotton
2022-03-29 13:11 ` [PATCH 3/6] doc: announce change in event queue conf structure Shijith Thotton
2022-03-29 13:11 ` [PATCH 4/6] test/event: test cases to test runtime queue attribute Shijith Thotton
2022-03-29 13:11 ` [PATCH 5/6] event/cnxk: support to set runtime queue attributes Shijith Thotton
2022-03-30 11:05   ` Van Haaren, Harry
2022-04-04  7:59     ` Shijith Thotton
2022-03-29 13:11 ` [PATCH 6/6] common/cnxk: use lock when accessing mbox of SSO Shijith Thotton
2022-03-29 18:49 ` [PATCH 0/6] Extend and set event queue attributes at runtime Jerin Jacob
2022-03-30 10:52   ` Van Haaren, Harry
2022-04-04  7:57     ` Shijith Thotton
2022-04-05  5:40 ` [PATCH v2 " Shijith Thotton
2022-04-05  5:40   ` [PATCH v2 1/6] eventdev: support to set " Shijith Thotton
2022-05-09 12:43     ` Jerin Jacob
2022-04-05  5:40   ` [PATCH v2 2/6] eventdev: add weight and affinity to queue attributes Shijith Thotton
2022-05-09 12:46     ` Jerin Jacob
2022-04-05  5:41   ` [PATCH v2 3/6] doc: announce change in event queue conf structure Shijith Thotton
2022-05-09 12:47     ` Jerin Jacob
2022-05-15 10:24     ` [PATCH v3] " Shijith Thotton
2022-07-12 14:05       ` Jerin Jacob
2022-07-13  6:52         ` [EXT] " Pavan Nikhilesh Bhagavatula
2022-07-13  8:55         ` Mattias Rönnblom
2022-07-13  9:56           ` Pavan Nikhilesh Bhagavatula
2022-07-17 12:52       ` Thomas Monjalon
2022-04-05  5:41   ` [PATCH v2 4/6] test/event: test cases to test runtime queue attribute Shijith Thotton
2022-05-09 12:55     ` Jerin Jacob [this message]
2022-04-05  5:41   ` [PATCH v2 5/6] event/cnxk: support to set runtime queue attributes Shijith Thotton
2022-05-09 12:57     ` Jerin Jacob
2022-04-05  5:41   ` [PATCH v2 6/6] common/cnxk: use lock when accessing mbox of SSO Shijith Thotton
2022-04-11 11:07   ` [PATCH v2 0/6] Extend and set event queue attributes at runtime Shijith Thotton
2022-05-15  9:53   ` [PATCH v3 0/5] " Shijith Thotton
2022-05-15  9:53     ` [PATCH v3 1/5] eventdev: support to set " Shijith Thotton
2022-05-15 13:11       ` Mattias Rönnblom
2022-05-16  3:57         ` Shijith Thotton
2022-05-16 10:23           ` Mattias Rönnblom
2022-05-16 12:12             ` Shijith Thotton
2022-05-15  9:53     ` [PATCH v3 2/5] eventdev: add weight and affinity to queue attributes Shijith Thotton
2022-05-15  9:53     ` [PATCH v3 3/5] test/event: test cases to test runtime queue attribute Shijith Thotton
2022-05-15  9:53     ` [PATCH v3 4/5] common/cnxk: use lock when accessing mbox of SSO Shijith Thotton
2022-05-15  9:53     ` [PATCH v3 5/5] event/cnxk: support to set runtime queue attributes Shijith Thotton
2022-05-16 17:35     ` [PATCH v4 0/5] Extend and set event queue attributes at runtime Shijith Thotton
2022-05-16 17:35       ` [PATCH v4 1/5] eventdev: support to set " Shijith Thotton
2022-05-16 18:02         ` Jerin Jacob
2022-05-17  8:55           ` Mattias Rönnblom
2022-05-17 13:35             ` Jerin Jacob
2022-05-19  8:49         ` Ray Kinsella
2022-05-16 17:35       ` [PATCH v4 2/5] eventdev: add weight and affinity to queue attributes Shijith Thotton
2022-05-16 17:35       ` [PATCH v4 3/5] test/event: test cases to test runtime queue attribute Shijith Thotton
2022-05-16 17:35       ` [PATCH v4 4/5] common/cnxk: use lock when accessing mbox of SSO Shijith Thotton
2022-05-16 17:35       ` [PATCH v4 5/5] event/cnxk: support to set runtime queue attributes Shijith Thotton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1P-4HTTHwX7+ed7h=m9_XEGy2D7LWjMOE=F5tkfmztrrg@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=jerinj@marvell.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=pbhagavatula@marvell.com \
    --cc=sthotton@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).