From: Jerin Jacob <jerinjacobk@gmail.com>
To: Shijith Thotton <sthotton@marvell.com>
Cc: dpdk-dev <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2] event/cnxk: fix SSO and TIM argument parsing
Date: Mon, 6 Sep 2021 14:21:00 +0530 [thread overview]
Message-ID: <CALBAE1P2bPMvWgFmx-XM_D32U_6dxnrXQf417H3TXNKJn1Q8gw@mail.gmail.com> (raw)
In-Reply-To: <208cb9f2657e889a9b750dcdf4ccf2f039333899.1630339233.git.sthotton@marvell.com>
On Mon, Aug 30, 2021 at 9:37 PM Shijith Thotton <sthotton@marvell.com> wrote:
>
> Type of kvargs value and handler function argument should match to avoid
> spilling memory.
>
> Fixes: 7ffa7379965e ("event/cnxk: add option to configure getwork mode")
Cc: stable@dpdk.org
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
> ---
> v2:
> * Rebased.
>
> drivers/event/cnxk/cnxk_eventdev.c | 6 +++---
> drivers/event/cnxk/cnxk_tim_evdev.h | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c
> index cfd7fb971c..be682bb0df 100644
> --- a/drivers/event/cnxk/cnxk_eventdev.c
> +++ b/drivers/event/cnxk/cnxk_eventdev.c
> @@ -571,11 +571,11 @@ cnxk_sso_parse_devargs(struct cnxk_sso_evdev *dev, struct rte_devargs *devargs)
> &dev->xae_cnt);
> rte_kvargs_process(kvlist, CNXK_SSO_GGRP_QOS, &parse_sso_kvargs_dict,
> dev);
> - rte_kvargs_process(kvlist, CNXK_SSO_FORCE_BP, &parse_kvargs_value,
> + rte_kvargs_process(kvlist, CNXK_SSO_FORCE_BP, &parse_kvargs_flag,
> &dev->force_ena_bp);
> - rte_kvargs_process(kvlist, CN9K_SSO_SINGLE_WS, &parse_kvargs_value,
> + rte_kvargs_process(kvlist, CN9K_SSO_SINGLE_WS, &parse_kvargs_flag,
> &single_ws);
> - rte_kvargs_process(kvlist, CN10K_SSO_GW_MODE, &parse_kvargs_value,
> + rte_kvargs_process(kvlist, CN10K_SSO_GW_MODE, &parse_kvargs_flag,
> &dev->gw_mode);
> dev->dual_ws = !single_ws;
> rte_kvargs_free(kvlist);
> diff --git a/drivers/event/cnxk/cnxk_tim_evdev.h b/drivers/event/cnxk/cnxk_tim_evdev.h
> index c369f6f472..8e25cef0c4 100644
> --- a/drivers/event/cnxk/cnxk_tim_evdev.h
> +++ b/drivers/event/cnxk/cnxk_tim_evdev.h
> @@ -90,8 +90,8 @@ struct cnxk_tim_evdev {
> uint32_t chunk_sz;
> /* Dev args */
> uint8_t disable_npa;
> - uint16_t chunk_slots;
> - uint16_t min_ring_cnt;
> + uint32_t chunk_slots;
> + uint32_t min_ring_cnt;
> uint8_t enable_stats;
> uint16_t ring_ctl_cnt;
> struct cnxk_tim_ctl *ring_ctl_data;
> --
> 2.25.1
>
prev parent reply other threads:[~2021-09-06 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 16:02 [dpdk-dev] [PATCH] " Shijith Thotton
2021-08-30 16:06 ` [dpdk-dev] [PATCH v2] " Shijith Thotton
2021-09-06 8:51 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1P2bPMvWgFmx-XM_D32U_6dxnrXQf417H3TXNKJn1Q8gw@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).