From: Jerin Jacob <jerinjacobk@gmail.com>
To: Shijith Thotton <sthotton@marvell.com>
Cc: ganapati.kundapura@intel.com, jerinj@marvell.com,
pbhagavatula@marvell.com, dev@dpdk.org, stable@dpdk.org,
Naga Harish K S V <s.v.naga.harish.k@intel.com>
Subject: Re: [PATCH] eventdev/eth_rx: fix return of rx adapter instance get
Date: Tue, 17 Jan 2023 20:49:14 +0530 [thread overview]
Message-ID: <CALBAE1PFu=_DH6AvjoF4b_ApnaOS32kM17pqO4_KYBuo=aCZVQ@mail.gmail.com> (raw)
In-Reply-To: <f4064ff0ebf4063203d6105bd86dfd2f72d74ec4.1672751275.git.sthotton@marvell.com>
On Tue, Jan 3, 2023 at 6:39 PM Shijith Thotton <sthotton@marvell.com> wrote:
>
> The API to get rx adapter instance is returning error for event devices
> with internal port capability and eth_rx_adapter_instance_get op
> undefined. But as the Rx adapter is internally maintaining the queue
> information needed to find the instance id, event devices can opt out
> from defining the op. Modified code to match this logic.
>
> Fixes: a1793ee8aba0 ("eventdev/eth_rx: add adapter instance get API")
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
@Naga Harish K, S V (rx_adapter maintainer) please review this patch.
> ---
> lib/eventdev/rte_event_eth_rx_adapter.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
> index cf7bbd4d69..170823a03c 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -3415,14 +3415,10 @@ rte_event_eth_rx_adapter_instance_get(uint16_t eth_dev_id,
> if (!rte_event_eth_rx_adapter_caps_get(rx_adapter->eventdev_id,
> eth_dev_id,
> &caps)) {
> - if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) {
> - ret = rxa_dev_instance_get(rx_adapter) ?
> - rxa_dev_instance_get(rx_adapter)
> - (eth_dev_id,
> - rx_queue_id,
> - rxa_inst_id)
> - : -EINVAL;
> - }
> + if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT &&
> + rxa_dev_instance_get(rx_adapter))
> + ret = rxa_dev_instance_get(rx_adapter)(eth_dev_id, rx_queue_id,
> + rxa_inst_id);
> }
>
> /* return if entry found */
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-01-17 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 13:09 Shijith Thotton
2023-01-17 15:19 ` Jerin Jacob [this message]
2023-02-07 7:17 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1PFu=_DH6AvjoF4b_ApnaOS32kM17pqO4_KYBuo=aCZVQ@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=ganapati.kundapura@intel.com \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
--cc=stable@dpdk.org \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).