From: Jerin Jacob <jerinjacobk@gmail.com>
To: Chengwen Feng <fengchengwen@huawei.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Cc: thomas@monjalon.net, dev@dpdk.org, ruifeng.wang@arm.com
Subject: Re: [PATCH] config/arm: make SoC-generic more generic
Date: Tue, 15 Nov 2022 12:38:16 +0530 [thread overview]
Message-ID: <CALBAE1Pc4UhMbhBbS6+oZcgszj-GE2=3vsprO_fjRj8cMgX+6A@mail.gmail.com> (raw)
In-Reply-To: <20221115020948.18356-1-fengchengwen@huawei.com>
On Tue, Nov 15, 2022 at 7:46 AM Chengwen Feng <fengchengwen@huawei.com> wrote:
>
> The non-generic soc has 1280 max-lcores and 32 max-numas, but the
> implementer-generic still has 256 max-lcores and 4 max-numas, which may
> result in restrictions on the use of binaries compiled by soc-generic
> in these systems.
>
> This patch changes the soc-generic max-lcores to 1280 and max-numas to
> 32 to make it more generic.
I think, it is not specific to ARM architecture issue. Even x86 config
set as below.
dpdk_conf.set('RTE_MAX_LCORE', 128)
dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
I think, it makes sense to keep generic as "most commonly used max"
per application, expectation cases can have separate config.
Also, this is for SINGLE application, even if you have 1280 cores a
single application most likely won't use that.
So in that way this patch is not needed.
>
> Also, because single numa is a special case of multiple numas, mark
> soc-generic's numa flag as true.
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
> config/arm/meson.build | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 6442ec9596..97b91cf609 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -32,8 +32,8 @@ implementer_generic = {
> 'flags': [
> ['RTE_MACHINE', '"armv8a"'],
> ['RTE_USE_C11_MEM_MODEL', true],
> - ['RTE_MAX_LCORE', 256],
> - ['RTE_MAX_NUMA_NODES', 4]
> + ['RTE_MAX_LCORE', 1280],
> + ['RTE_MAX_NUMA_NODES', 32]
> ],
> 'part_number_config': {
> 'generic': {
> @@ -271,7 +271,8 @@ implementers = {
> soc_generic = {
> 'description': 'Generic un-optimized build for armv8 aarch64 exec mode',
> 'implementer': 'generic',
> - 'part_number': 'generic'
> + 'part_number': 'generic',
> + 'numa': true
> }
>
> soc_generic_aarch32 = {
> --
> 2.17.1
>
next prev parent reply other threads:[~2022-11-15 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 2:09 Chengwen Feng
2022-11-15 7:08 ` Jerin Jacob [this message]
2022-11-15 7:55 ` fengchengwen
2022-11-15 8:20 ` Ruifeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1Pc4UhMbhBbS6+oZcgszj-GE2=3vsprO_fjRj8cMgX+6A@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).