From: Jerin Jacob <jerinjacobk@gmail.com>
To: Srikanth Yalavarthi <syalavarthi@marvell.com>
Cc: "Thomas Monjalon" <thomas@monjalon.net>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Jerin Jacob" <jerinj@marvell.com>,
dev@dpdk.org, sshankarnara@marvell.com, aprabhu@marvell.com,
ptakkar@marvell.com,
"Amit Prakash Shukla" <amitprakashs@marvell.com>,
"Sachin Saxena" <sachin.saxena@oss.nxp.com>,
"Hemant Agrawal" <hemant.agrawal@nxp.com>,
"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
"Naga Harish K, S V" <s.v.naga.harish.k@intel.com>,
"Erik Gabriel Carrillo" <erik.g.carrillo@intel.com>,
"McDaniel, Timothy" <timothy.mcdaniel@intel.com>,
"Pavan Nikhilesh" <pbhagavatula@marvell.com>,
"Shijith Thotton" <sthotton@marvell.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Peter Mccarthy" <peter.mccarthy@intel.com>
Subject: Re: [RFC PATCH v2 1/1] eventdev: introduce ML event adapter library
Date: Fri, 18 Aug 2023 15:15:11 +0530 [thread overview]
Message-ID: <CALBAE1Pg90TzZHSyxXpa7Niz=h_tTg14q7PJXJewKc-s4WV2TA@mail.gmail.com> (raw)
In-Reply-To: <20230801070016.340-2-syalavarthi@marvell.com>
On Tue, Aug 1, 2023 at 12:30 PM Srikanth Yalavarthi
<syalavarthi@marvell.com> wrote:
>
> Introduce event ML adapter APIs. This patch provides information
> on adapter modes and usage. Application can use this event adapter
> interface to transfer packets between ML device and event device.
>
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
Adding other eventdev maintainers
Found a doc build issue
/export/dpdk-next-eventdev/lib/eventdev/rte_eventdev.h:1489: error:
argument 'id' of command @param is not found in the argument list of
rte_event_ml_adapter_caps_get(uint8_t dev_id, int16_t mldev_id,
uint32_t *caps) (warning treated as err
or, aborting now)
> ---
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 18bc05fccd..3f9d4d2c43 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -544,6 +544,12 @@ F: drivers/raw/skeleton/
> F: app/test/test_rawdev.c
> F: doc/guides/prog_guide/rawdev.rst
>
> +Eventdev ML Adapter API
> +M: Srikanth Yalavarthi <syalavarthi@marvell.com>
> +T: git://dpdk.org/next/dpdk-next-eventdev
> +F: lib/eventdev/*ml_adapter*
> +F: doc/guides/prog_guide/event_ml_adapter.rst
Keep next to "Eventdev Crypto Adapter API".
> +
> +/**
> + * Enqueue a burst of ML operations as event objects supplied in *rte_event* structure on an event
> + * ML adapter designated by its event *evdev_id* through the event port specified by *port_id*. This
> + * function is supported if the eventdev PMD has the #RTE_EVENT_ML_ADAPTER_CAP_INTERNAL_PORT_OP_FWD
> + * capability flag set.
> + *
> + * The *nb_events* parameter is the number of event objects to enqueue that are supplied in the
> + * *ev* array of *rte_event* structure.
> + *
> + * The rte_event_ml_adapter_enqueue() function returns the number of event objects it actually
> + * enqueued. A return value equal to *nb_events* means that all event objects have been enqueued.
> + *
> + * @param evdev_id
> + * The identifier of the device.
> + * @param port_id
> + * The identifier of the event port.
> + * @param ev
> + * Points to an array of *nb_events* objects of type *rte_event* structure which contain the
> + * event object enqueue operations to be processed.
> + * @param nb_events
> + * The number of event objects to enqueue, typically number of
> + * rte_event_port_attr_get(...RTE_EVENT_PORT_ATTR_ENQ_DEPTH...) available for this port.
> + *
> + * @return
> + * The number of event objects actually enqueued on the event device. The return value can be
> + * less than the value of the *nb_events* parameter when the event devices queue is full or if
> + * invalid parameters are specified in a *rte_event*. If the return value is less than *nb_events*,
> + * the remaining events at the end of ev[] are not consumed and the caller has to take care of them,
> + * and rte_errno is set accordingly. Possible errno values include:
> + *
Error code is not rendering properly in html doc
> + * - EINVAL: The port ID is invalid, device ID is invalid, an event's queue ID is invalid, or an
> + * event's sched type doesn't match the capabilities of the destination queue.
> + * - ENOSPC: The event port was backpressured and unable to enqueue one or more events. This
> + * error code is only applicable to closed systems.
> + */
> +uint16_t
> +rte_event_ml_adapter_enqueue(uint8_t evdev_id, uint8_t port_id, struct rte_event ev[],
> + uint16_t nb_events);
> diff --git a/lib/mldev/rte_mldev.h b/lib/mldev/rte_mldev.h
> index 222ecbdbe1..a14437eb72 100644
> --- a/lib/mldev/rte_mldev.h
> +++ b/lib/mldev/rte_mldev.h
> @@ -449,6 +449,12 @@ struct rte_ml_op {
> * dequeue and enqueue operation.
> * The application should not modify this field.
> */
> + uint32_t private_data_offset;
> + /**< Offset to indicate start of private data (if any).
> + * The offset is counted from the start of the rte_ml_op.
> + * The offset provides an offset to locate the request /
> + * response information in the rte_ml_op.
Could you move this change out of event adapter changes.i.e merged
through main tree.
> + */
> } __rte_cache_aligned;
Since it is similar to crypto adapter, no more review comments.
If there are further review comments in mailing list, please work on
v1 with test application and driver changes.
prev parent reply other threads:[~2023-08-18 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 4:12 [RFC PATCH 0/1] Introduce Event ML Adapter Srikanth Yalavarthi
2023-04-23 4:12 ` [RFC PATCH 1/1] eventdev: introduce ML event adapter library Srikanth Yalavarthi
2023-08-01 7:00 ` [RFC PATCH v2 0/1] Introduce Event ML Adapter Srikanth Yalavarthi
2023-08-01 7:00 ` [RFC PATCH v2 1/1] eventdev: introduce ML event adapter library Srikanth Yalavarthi
2023-08-18 9:45 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1Pg90TzZHSyxXpa7Niz=h_tTg14q7PJXJewKc-s4WV2TA@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=abhinandan.gujjar@intel.com \
--cc=amitprakashs@marvell.com \
--cc=aprabhu@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=pbhagavatula@marvell.com \
--cc=peter.mccarthy@intel.com \
--cc=ptakkar@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=sshankarnara@marvell.com \
--cc=sthotton@marvell.com \
--cc=syalavarthi@marvell.com \
--cc=thomas@monjalon.net \
--cc=timothy.mcdaniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).