From: William Tu <u9012063@gmail.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dpdk-dev <dev@dpdk.org>, Pallavi Kadam <pallavi.kadam@intel.com>,
jizh@linux.microsoft.com, "Richardson,
Bruce" <bruce.richardson@intel.com>, Ray Kinsella <mdr@ashroe.eu>,
Ranjit Menon <ranjit.menon@intel.com>,
Tal Shnaiderman <talshn@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] eal/windows: fix export list
Date: Wed, 1 Sep 2021 10:21:19 -0700 [thread overview]
Message-ID: <CALDO+SYWfL58_GHpTC2syneFCPW91Lw2725-A3GVdyt1o7FsVQ@mail.gmail.com> (raw)
In-Reply-To: <20210829021602.290466-3-dmitry.kozliuk@gmail.com>
On Sat, Aug 28, 2021 at 7:16 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
>
> * Version and randomness API were not added to .def file by mistake,
> which is why they were later excluded from the export list.
> * Device API stubs were added to EAL but not exported.
>
> Fixes: edd66d57d55c ("eal/windows: add random function")
> Fixes: 3d2fcb0e0aec ("eal/windows: add device event stubs")
> Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime")
> Cc: pallavi.kadam@intel.com
> Cc: jizh@linux.microsoft.com
> Cc: bruce.richardson@intel.com
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
LGTM, thanks.
Acked-by: William Tu <u9012063@gmail.com>
next prev parent reply other threads:[~2021-09-01 17:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 2:16 [dpdk-dev] [PATCH 0/2] eal/windows: restore mistakenly hidden API Dmitry Kozlyuk
2021-08-29 2:16 ` [dpdk-dev] [PATCH 1/2] eal: remove Windows-specific list of common files Dmitry Kozlyuk
2021-09-01 17:20 ` William Tu
2021-08-29 2:16 ` [dpdk-dev] [PATCH 2/2] eal/windows: fix export list Dmitry Kozlyuk
2021-09-01 17:21 ` William Tu [this message]
2021-09-01 19:35 ` [dpdk-dev] [PATCH 0/2] eal/windows: restore mistakenly hidden API Menon, Ranjit
2021-09-30 20:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDO+SYWfL58_GHpTC2syneFCPW91Lw2725-A3GVdyt1o7FsVQ@mail.gmail.com \
--to=u9012063@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=jizh@linux.microsoft.com \
--cc=mdr@ashroe.eu \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).