From: Ed Czeck <ed.czeck@atomicrules.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, John Miller <john.miller@atomicrules.com>,
Shepard Siegel <shepard.siegel@atomicrules.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/ark: report hardware status during PMD init
Date: Tue, 11 Apr 2017 11:26:26 -0400 [thread overview]
Message-ID: <CALZ3GuhuMYBoxcRFkpjZeotmeV6Gpx7zmXD7_ipNyQ=NEdkFmA@mail.gmail.com> (raw)
In-Reply-To: <5bb8278f-a3b1-01bc-6161-33c73e9731a4@intel.com>
On Mon, Apr 10, 2017 at 11:01 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:
> On 4/10/2017 1:26 PM, Ed Czeck wrote:
> > Expose additional fpga status registers and report
> > conditions during PMD init
> >
>
> > + if (ark->sysctrl.t32[3] != 0) {
> > + if (ark_rqp_lasped(ark->rqpacing))
> > + PMD_DRV_LOG(INFO, "Arkville Evaluation System - "
>
> Is this should be "info" level or debug, is end user interested if timer
> expired or not?
>
> These messages are intended for the user. After internal discussion we
promoted them to warning and error.
> > + "Timer has Expired\n");
> > + else
> > + PMD_DRV_LOG(INFO, "Arkville Evaluation System - "
>
> btw, what is the logic in pmd, when to use PMD_DRV_LOG and when to use
> PMD_DEBUG_LOG?
The PMD_DRV_LOG macro is a local wrapper on RTE_LOG, while the
PMD_DEBUG_LOG macro is a compile-time conditional macro to the same
RTE_LOG. The DEBUG_LOG macro is conditionalize on the configuration
RTE_LIBRTE_ARK_DEBUG_TRACE.
> > + "Timer is Running\n");
> > + }
> > +
> >
>
> Extra line.
>
Removed.
Thank you
next prev parent reply other threads:[~2017-04-11 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 12:26 [dpdk-dev] [PATCH 1/2] net/ark: update packet Rx path to set mbuf time stamp field Ed Czeck
2017-04-10 12:26 ` [dpdk-dev] [PATCH 2/2] net/ark: report hardware status during PMD init Ed Czeck
2017-04-10 15:01 ` Ferruh Yigit
2017-04-11 15:26 ` Ed Czeck [this message]
2017-04-11 15:41 ` [dpdk-dev] [PATCH v2 " Ed Czeck
2017-04-11 18:06 ` john miller
2017-04-11 10:10 ` [dpdk-dev] [PATCH 1/2] net/ark: update packet Rx path to set mbuf time stamp field john miller
2017-04-11 15:41 ` [dpdk-dev] [PATCH v2 " Ed Czeck
2017-04-11 15:54 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALZ3GuhuMYBoxcRFkpjZeotmeV6Gpx7zmXD7_ipNyQ=NEdkFmA@mail.gmail.com' \
--to=ed.czeck@atomicrules.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.miller@atomicrules.com \
--cc=shepard.siegel@atomicrules.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).