From: Ed Czeck <ed.czeck@atomicrules.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 5/7] net/ark: Packet TX support initial version
Date: Thu, 23 Mar 2017 17:44:12 -0400 [thread overview]
Message-ID: <CALZ3Gui3Rtgz5D8kyqRJP7qM5oBP+6O7K2cUYa=zJ-042VhNjA@mail.gmail.com> (raw)
In-Reply-To: <4480ae16-df81-c30e-ef5c-995081fa9338@intel.com>
On Thu, Mar 23, 2017 at 8:14 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:
>
> On 3/23/2017 1:03 AM, Ed Czeck wrote:
>
> Is this function to get dev->data->port_id ?
>
> "struct ark_adapter" is private date per eth_dev, it is possible to keep
> port_id per ark, no need to keep whole array on each ark, if I am now
> missing anything ...
Code changed to grab port from private data
>
> Why not using RTE_LIBRTE_ARK_PAD_TX directly, but creating another macro?
This macro is either defined as 1 or nothing. We are changing from these
states to 1 or 0. Is there a preferred style or example that we should
study?
>
> Is it possible to handle RTE_LIBRTE_ARK_DEBUG_TX in log.h file to create
> a ..LOG_TX macro and use it, instead of dealing here with new macros?
We are reviewing the use of debug and macro internally. Is there
a preferred style or example that we should study?
> > +/* Forward declarations */
> > +struct rte_mbuf;
> > +struct rte_eth_dev;
> > +struct rte_eth_stats;
> > +struct rte_eth_txconf;
>
> Why not include relevant headers, instead of these struct declarations.
The use of bare declaration is all that is needed, since the header only
uses pointers to these structs, and the full include is not needed. Full
header included were added.
next prev parent reply other threads:[~2017-03-23 21:44 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 1:03 [dpdk-dev] [PATCH v4 1/7] net/ark: PMD for Atomic Rules Arkville driver stub Ed Czeck
2017-03-23 1:03 ` [dpdk-dev] [PATCH v4 2/7] net/ark: HW API part 1 of 3 Ed Czeck
2017-03-23 11:38 ` Ferruh Yigit
2017-03-23 20:33 ` Ed Czeck
2017-03-29 1:05 ` [dpdk-dev] [PATCH v6 2/7] net/ark: Provide API for hardware modules mpu, rqp, and pktdir Ed Czeck
2017-03-29 21:32 ` [dpdk-dev] [PATCH v7 2/7] net/ark: provide API for hardware modules mpu rqp " Ed Czeck
2017-04-04 19:50 ` [dpdk-dev] [PATCH v8 " Ed Czeck
2017-03-23 1:03 ` [dpdk-dev] [PATCH v4 3/7] net/ark: HW API part 2 of 3 Ed Czeck
2017-03-29 1:05 ` [dpdk-dev] [PATCH v6 3/7] net/ark: Provide API for hardware modules udm and ddm Ed Czeck
2017-03-29 21:33 ` [dpdk-dev] [PATCH v7 3/7] net/ark: provide " Ed Czeck
2017-04-04 19:50 ` [dpdk-dev] [PATCH v8 " Ed Czeck
2017-03-23 1:03 ` [dpdk-dev] [PATCH v4 4/7] net/ark: HW API part 3 of 3 Ed Czeck
2017-03-29 1:06 ` [dpdk-dev] [PATCH v6 4/7] net/ark: Provide API for hardware modules pktchkr and pktgen Ed Czeck
2017-03-29 21:34 ` [dpdk-dev] [PATCH v7 4/7] net/ark: provide " Ed Czeck
2017-04-04 19:50 ` [dpdk-dev] [PATCH v8 " Ed Czeck
2017-03-23 1:03 ` [dpdk-dev] [PATCH v4 5/7] net/ark: Packet TX support initial version Ed Czeck
2017-03-23 12:14 ` Ferruh Yigit
2017-03-23 21:44 ` Ed Czeck [this message]
2017-03-29 1:06 ` [dpdk-dev] [PATCH v6 " Ed Czeck
2017-03-29 21:34 ` [dpdk-dev] [PATCH v7 5/7] net/ark: packet Tx " Ed Czeck
2017-04-04 19:51 ` [dpdk-dev] [PATCH v8 " Ed Czeck
2017-03-23 1:03 ` [dpdk-dev] [PATCH v4 6/7] net/ark: Packet RX " Ed Czeck
2017-03-23 12:14 ` Ferruh Yigit
2017-03-23 21:51 ` Ed Czeck
2017-03-29 1:06 ` [dpdk-dev] [PATCH v6 " Ed Czeck
2017-03-29 21:35 ` [dpdk-dev] [PATCH v7 6/7] net/ark: packet Rx " Ed Czeck
2017-04-04 19:51 ` [dpdk-dev] [PATCH v8 " Ed Czeck
2017-03-23 1:03 ` [dpdk-dev] [PATCH v4 7/7] net/ark: Arkville PMD component integration Ed Czeck
2017-03-23 12:13 ` Ferruh Yigit
2017-03-23 22:19 ` Ed Czeck
2017-03-28 12:34 ` Ferruh Yigit
2017-03-29 1:07 ` [dpdk-dev] [PATCH v6 " Ed Czeck
2017-03-29 9:54 ` Ferruh Yigit
2017-03-29 21:35 ` [dpdk-dev] [PATCH v7 7/7] net/ark: arkville " Ed Czeck
2017-04-04 19:51 ` [dpdk-dev] [PATCH v8 " Ed Czeck
2017-03-23 11:36 ` [dpdk-dev] [PATCH v4 1/7] net/ark: PMD for Atomic Rules Arkville driver stub Ferruh Yigit
2017-03-23 13:08 ` Ferruh Yigit
2017-03-23 19:46 ` Ed Czeck
2017-03-28 12:58 ` Ferruh Yigit
2017-03-28 21:11 ` Ed Czeck
2017-03-29 9:42 ` Ferruh Yigit
2017-03-23 22:59 ` [dpdk-dev] [PATCH v5 " Ed Czeck
2017-03-23 23:00 ` [dpdk-dev] [PATCH v5 2/7] net/ark: provide api to hardware module mpu, rqp, and pktdir Ed Czeck
2017-03-28 14:35 ` Ferruh Yigit
2017-03-28 20:14 ` Ed Czeck
2017-03-23 23:00 ` [dpdk-dev] [PATCH v5 3/7] net/ark: provide API hardware module udm and ddm Ed Czeck
2017-03-23 23:00 ` [dpdk-dev] [PATCH v5 4/7] net/ark: prrovide api for hardware module pktchkr and pktgen Ed Czeck
2017-03-23 23:00 ` [dpdk-dev] [PATCH v5 5/7] net/ark: Packet TX support initial version Ed Czeck
2017-03-23 23:01 ` [dpdk-dev] [PATCH v5 6/7] net/ark: Packet RX " Ed Czeck
2017-03-28 14:36 ` Ferruh Yigit
2017-03-28 21:59 ` Ed Czeck
2017-03-23 23:01 ` [dpdk-dev] [PATCH v5 7/7] net/ark: Arkville PMD component integration Ed Czeck
2017-03-28 14:38 ` Ferruh Yigit
2017-03-28 15:00 ` Adrien Mazarguil
2017-03-28 22:42 ` Ed Czeck
2017-03-28 14:34 ` [dpdk-dev] [PATCH v5 1/7] net/ark: PMD for Atomic Rules Arkville driver stub Ferruh Yigit
2017-03-28 22:38 ` Ed Czeck
2017-03-28 14:41 ` Ferruh Yigit
2017-03-29 1:04 ` [dpdk-dev] [PATCH v6 " Ed Czeck
2017-03-29 21:32 ` [dpdk-dev] [PATCH v7 1/7] net/ark: stub PMD for Atomic Rules Arkville Ed Czeck
2017-03-31 14:51 ` Ferruh Yigit
2017-03-31 15:09 ` Shepard Siegel
2017-04-04 20:58 ` Ed Czeck
2017-04-04 19:50 ` [dpdk-dev] [PATCH v8 " Ed Czeck
2017-04-07 10:54 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALZ3Gui3Rtgz5D8kyqRJP7qM5oBP+6O7K2cUYa=zJ-042VhNjA@mail.gmail.com' \
--to=ed.czeck@atomicrules.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).